This is an archive of the discontinued LLVM Phabricator instance.

Differential D30433

[AMDGPU] Change amd_kernel_code_t's minor version to 1
ClosedPublic

Authored by kzhuravl on Feb 27 2017, 3:07 PM.

Details

Reviewers
arsenm
Commits
rG182e9cc6d542: [AMDGPU] Change amd_kernel_code_t's minor version to 1 - We do emit…
rL296489: [AMDGPU] Change amd_kernel_code_t's minor version to 1
Summary
  • We do emit amd_kernel_code_t v1.1

Diff Detail

Event Timeline

kzhuravl created this revision.Feb 27 2017, 3:07 PM
Herald added subscribers: tpr, dstuttard, tony-tye and 4 others. · View Herald TranscriptFeb 27 2017, 3:07 PM
arsenm accepted this revision.Feb 27 2017, 3:15 PM

LGTM

This revision is now accepted and ready to land.Feb 27 2017, 3:15 PM
Closed by commit rL296489: [AMDGPU] Change amd_kernel_code_t's minor version to 1 (authored by kzhuravl). · Explain WhyFeb 28 2017, 9:29 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
lib/
Target/
AMDGPU/
Utils/
2 lines
test/
MC/
AMDGPU/
2 lines
2 lines

Diff 89946

lib/Target/AMDGPU/Utils/AMDGPUBaseInfo.cpp

Show First 20 Lines • Show All 301 Lines • ▼ Show 20 Lines
void initDefaultAMDKernelCodeT(amd_kernel_code_t &Header, void initDefaultAMDKernelCodeT(amd_kernel_code_t &Header,
const FeatureBitset &Features) { const FeatureBitset &Features) {
IsaInfo::IsaVersion ISA = IsaInfo::getIsaVersion(Features); IsaInfo::IsaVersion ISA = IsaInfo::getIsaVersion(Features);
memset(&Header, 0, sizeof(Header)); memset(&Header, 0, sizeof(Header));
Header.amd_kernel_code_version_major = 1; Header.amd_kernel_code_version_major = 1;
Header.amd_kernel_code_version_minor = 0; Header.amd_kernel_code_version_minor = 1;
Header.amd_machine_kind = 1; // AMD_MACHINE_KIND_AMDGPU Header.amd_machine_kind = 1; // AMD_MACHINE_KIND_AMDGPU
Header.amd_machine_version_major = ISA.Major; Header.amd_machine_version_major = ISA.Major;
Header.amd_machine_version_minor = ISA.Minor; Header.amd_machine_version_minor = ISA.Minor;
Header.amd_machine_version_stepping = ISA.Stepping; Header.amd_machine_version_stepping = ISA.Stepping;
Header.kernel_code_entry_byte_offset = sizeof(Header); Header.kernel_code_entry_byte_offset = sizeof(Header);
// wavefront_size is specified as a power of 2: 2^6 = 64 threads. // wavefront_size is specified as a power of 2: 2^6 = 64 threads.
Header.wavefront_size = 6; Header.wavefront_size = 6;
▲ Show 20 Lines • Show All 395 Lines • Show Last 20 Lines

test/MC/AMDGPU/hsa-exp.s

Show First 20 Lines • Show All 59 Lines • ▼ Show 20 Lines
// Make sure a line with whitespace won't break anything: // Make sure a line with whitespace won't break anything:
workitem_vgpr_count = 16 workitem_vgpr_count = 16
.end_amd_kernel_code_t .end_amd_kernel_code_t
// ASM-LABEL: {{^}}amd_kernel_code_t_minimal: // ASM-LABEL: {{^}}amd_kernel_code_t_minimal:
// ASM: .amd_kernel_code_t // ASM: .amd_kernel_code_t
// ASM: amd_code_version_major = 7 // ASM: amd_code_version_major = 7
// ASM: amd_code_version_minor = 0 // ASM: amd_code_version_minor = 1
// ASM: amd_machine_kind = 1 // ASM: amd_machine_kind = 1
// ASM: amd_machine_version_major = 7 // ASM: amd_machine_version_major = 7
// ASM: amd_machine_version_minor = 0 // ASM: amd_machine_version_minor = 0
// ASM: amd_machine_version_stepping = 0 // ASM: amd_machine_version_stepping = 0
// ASM: kernel_code_entry_byte_offset = 256 // ASM: kernel_code_entry_byte_offset = 256
// ASM: kernel_code_prefetch_byte_size = 0 // ASM: kernel_code_prefetch_byte_size = 0
// ASM: max_scratch_backing_memory_byte_size = 0 // ASM: max_scratch_backing_memory_byte_size = 0
// ASM: granulated_workitem_vgpr_count = 1 // ASM: granulated_workitem_vgpr_count = 1
▲ Show 20 Lines • Show All 53 Lines • Show Last 20 Lines

test/MC/AMDGPU/hsa.s

Show First 20 Lines • Show All 208 Lines • ▼ Show 20 Lines
// Make sure a line with whitespace won't break anything: // Make sure a line with whitespace won't break anything:
workitem_vgpr_count = 16 workitem_vgpr_count = 16
.end_amd_kernel_code_t .end_amd_kernel_code_t
// ASM-LABEL: {{^}}amd_kernel_code_t_minimal: // ASM-LABEL: {{^}}amd_kernel_code_t_minimal:
// ASM: .amd_kernel_code_t // ASM: .amd_kernel_code_t
// ASM: amd_code_version_major = 1 // ASM: amd_code_version_major = 1
// ASM: amd_code_version_minor = 0 // ASM: amd_code_version_minor = 1
// ASM: amd_machine_kind = 1 // ASM: amd_machine_kind = 1
// ASM: amd_machine_version_major = 7 // ASM: amd_machine_version_major = 7
// ASM: amd_machine_version_minor = 0 // ASM: amd_machine_version_minor = 0
// ASM: amd_machine_version_stepping = 0 // ASM: amd_machine_version_stepping = 0
// ASM: kernel_code_entry_byte_offset = 256 // ASM: kernel_code_entry_byte_offset = 256
// ASM: kernel_code_prefetch_byte_size = 0 // ASM: kernel_code_prefetch_byte_size = 0
// ASM: max_scratch_backing_memory_byte_size = 0 // ASM: max_scratch_backing_memory_byte_size = 0
// ASM: granulated_workitem_vgpr_count = 1 // ASM: granulated_workitem_vgpr_count = 1
▲ Show 20 Lines • Show All 53 Lines • Show Last 20 Lines