This is an archive of the discontinued LLVM Phabricator instance.

[NFC] Generate .dot graph with monospace font for blocks, making it easier to read
AbandonedPublic

Authored by bollu on Feb 27 2017, 11:27 AM.

Event Timeline

bollu created this revision.Feb 27 2017, 11:27 AM
grosser edited edge metadata.Feb 28 2017, 12:08 PM

This is a pretty subjective choice, I suppose. However, as must editors use monospace and that's where LLVM-IR is looked at most of the time, this likely makes sense. From my perspective this is fine. I leave some time for others to see if they have a differing opinion.

sunfish edited edge metadata.Feb 28 2017, 12:15 PM

My only concern would be if this significantly changes the overall size of nodes. Really big nodes sometimes make edges harder to read.

The size is relative (you can always zoom).

The shapes get relatively a little wider and less high.

In terms of readability, it seems to me that at the same size of text the monospace font is better readable (as a programming language). This is most visible when zooming out and font becomes very small. Again, this might be a subjective feeling.

From my feeling monospace font improves the readability a bit.

bollu abandoned this revision.Apr 24 2017, 3:38 PM