This is an archive of the discontinued LLVM Phabricator instance.

AMDGPU: export s_waitcnt builtin
ClosedPublic

Authored by jvesely on Feb 24 2017, 3:45 PM.

Diff Detail

Repository
rL LLVM

Event Timeline

jvesely created this revision.Feb 24 2017, 3:45 PM
arsenm added inline comments.Feb 24 2017, 4:36 PM
test/CodeGenOpenCL/builtins-amdgcn.cl
272 ↗(On Diff #89739)

Should also have a test in builtins-amdgcn-error.cl that a non-constant input is rejected

jvesely updated this revision to Diff 89760.Feb 24 2017, 6:07 PM

force parameter to be integer immediate

jvesely marked an inline comment as done.Feb 24 2017, 6:07 PM
arsenm accepted this revision.Feb 24 2017, 6:09 PM

LGTM

This revision is now accepted and ready to land.Feb 24 2017, 6:09 PM
This revision was automatically updated to reflect the committed changes.