Fix an obvious bug in SampleProfileReaderGCC.

[danielcdh]

Summary

The CallTargetProfile should be added to FProfile to be consistent with other profile readers.

[davidxl]

Is it possible to add a test?

[danielcdh]

add unittest

[davidxl]

test/Transforms/SampleProfile/indirect-call.ll

5 ↗

(On Diff #89301)

is there a need for the GCC prefix? The pattern is the same as the existing one.

[danielcdh]

test/Transforms/SampleProfile/indirect-call.ll

5 ↗

(On Diff #89301)

The gcc version of the profile only contains the profile for "test". As there is no tool to convert llvm profile to gcc format, I need to manually fake a gcc profile, which is not easy when there is inline stack.

[davidxl]

lgtm

[danielcdh]

The gcc reader does not work on certain architectures. Move the tests to a separate file and added XFAIL for those architectures.

lib/ProfileData/SampleProfReader.cpp

for (uint32_t J = 0; J < NumTargets; J++) {
       if (!GcovBuffer.readInt64(TargetIdx))
         return sampleprof_error::truncated;
       StringRef TargetName(Names[TargetIdx]);
 
       uint64_t TargetCount;
       if (!GcovBuffer.readInt64(TargetCount))
         return sampleprof_error::truncated;
 
-      if (Update) {
-        FunctionSamples &TargetProfile = Profiles[TargetName];
-        TargetProfile.addCalledTargetSamples(LineOffset, Discriminator,
-                                             TargetName, TargetCount);
-      }
-    }
-  }
+      if (Update)
+        FProfile->addCalledTargetSamples(LineOffset, Discriminator,
 
   // Process all the inlined callers into the current function. These
   // are all the callsites that were inlined into this function.
   for (uint32_t I = 0; I < NumCallsites; I++) {
     // The offset is encoded as:
     //   high 16 bits: line offset to the start of the function.
     //   low 16 bits: discriminator.
     uint32_t Offset;