Details
Details
- Reviewers
artem.tamazov mareko
Diff Detail
Diff Detail
Event Timeline
Comment Actions
Comments need to be updated at least.
lib/Target/AMDGPU/SIFoldOperands.cpp | ||
---|---|---|
788–790 | Output modifiers are not compatible with output denorms, i.e.:
Output modifiers are not IEEE compliant (-0*x=+0). Output modifiers are ignored by hardware if ieee bit is set in the HW MODE register. The above applies to all supported floating types, including f16, f32, f64. | |
827 | Nope. Pls. see comment above. | |
851 | Yes. If IEEE is set, OMOD does not work. |
Comment Actions
Other than that, nice work.
lib/Target/AMDGPU/AMDGPUCallingConv.td | ||
---|---|---|
38 ↗ | (On Diff #89459) | Why are the calling conventions being changed? |
lib/Target/AMDGPU/AMDGPUCallingConv.td | ||
---|---|---|
38 ↗ | (On Diff #89459) | I needed a way to get an f16 input into a graphics shader. This would just assert on unhandled value type before. I can commit this separately |
lib/Target/AMDGPU/AMDGPUCallingConv.td | ||
---|---|---|
38 ↗ | (On Diff #89459) | OK. I guess you can keep it here. |
Output modifiers are not compatible with output denorms, i.e.:
Output modifiers are not IEEE compliant (-0*x=+0). Output modifiers are ignored by hardware if ieee bit is set in the HW MODE register.
The above applies to all supported floating types, including f16, f32, f64.