This is an archive of the discontinued LLVM Phabricator instance.

Enable PROFILE, TSAN and UBSAN for Android
ClosedPublic

Authored by pirama on Feb 17 2017, 4:44 PM.

Download Raw Diff

Details

Reviewers

Commits

rGa84404c7a46f: Enable PROFILE, TSAN and UBSAN for Android
rCRT295523: Enable PROFILE, TSAN and UBSAN for Android
rL295523: Enable PROFILE, TSAN and UBSAN for Android

Summary

These sanitizers are enabled and used in Android but got built with
Android's build system. This change enables them in the CMake build
system.

Diff Detail

Build Status

Buildable 4101
Build 4101: arc lint + arc unit

Event Timeline

pirama created this revision.Feb 17 2017, 4:44 PM

Herald added subscribers: mgorny, danalbert. · View Herald TranscriptFeb 17 2017, 4:44 PM

LGTM

This revision is now accepted and ready to land.Feb 17 2017, 4:50 PM

Closed by commit rL295523: Enable PROFILE, TSAN and UBSAN for Android (authored by pirama). · Explain WhyFeb 17 2017, 5:24 PM

This revision was automatically updated to reflect the committed changes.

r295523. Thanks Evgeniy!

Revision Contents

Path

Size

cmake/

config-ix.cmake

6 lines

Diff 88993

cmake/config-ix.cmake

	Show First 20 Lines • Show All 479 Lines • ▼ Show 20 Lines
	if (COMPILER_RT_HAS_SANITIZER_COMMON AND MSAN_SUPPORTED_ARCH AND			if (COMPILER_RT_HAS_SANITIZER_COMMON AND MSAN_SUPPORTED_ARCH AND
	OS_NAME MATCHES "Linux")			OS_NAME MATCHES "Linux")
	set(COMPILER_RT_HAS_MSAN TRUE)			set(COMPILER_RT_HAS_MSAN TRUE)
	else()			else()
	set(COMPILER_RT_HAS_MSAN FALSE)			set(COMPILER_RT_HAS_MSAN FALSE)
	endif()			endif()

	if (PROFILE_SUPPORTED_ARCH AND NOT LLVM_USE_SANITIZER AND			if (PROFILE_SUPPORTED_ARCH AND NOT LLVM_USE_SANITIZER AND
	OS_NAME MATCHES "Darwin\|Linux\|FreeBSD\|Windows")			OS_NAME MATCHES "Darwin\|Linux\|FreeBSD\|Windows\|Android")
	set(COMPILER_RT_HAS_PROFILE TRUE)			set(COMPILER_RT_HAS_PROFILE TRUE)
	else()			else()
	set(COMPILER_RT_HAS_PROFILE FALSE)			set(COMPILER_RT_HAS_PROFILE FALSE)
	endif()			endif()

	if (COMPILER_RT_HAS_SANITIZER_COMMON AND TSAN_SUPPORTED_ARCH AND			if (COMPILER_RT_HAS_SANITIZER_COMMON AND TSAN_SUPPORTED_ARCH AND
	OS_NAME MATCHES "Darwin\|Linux\|FreeBSD")			OS_NAME MATCHES "Darwin\|Linux\|FreeBSD\|Android")
	set(COMPILER_RT_HAS_TSAN TRUE)			set(COMPILER_RT_HAS_TSAN TRUE)
	else()			else()
	set(COMPILER_RT_HAS_TSAN FALSE)			set(COMPILER_RT_HAS_TSAN FALSE)
	endif()			endif()

	if (COMPILER_RT_HAS_SANITIZER_COMMON AND UBSAN_SUPPORTED_ARCH AND			if (COMPILER_RT_HAS_SANITIZER_COMMON AND UBSAN_SUPPORTED_ARCH AND
	OS_NAME MATCHES "Darwin\|Linux\|FreeBSD\|Windows")			OS_NAME MATCHES "Darwin\|Linux\|FreeBSD\|Windows\|Android")
	set(COMPILER_RT_HAS_UBSAN TRUE)			set(COMPILER_RT_HAS_UBSAN TRUE)
	else()			else()
	set(COMPILER_RT_HAS_UBSAN FALSE)			set(COMPILER_RT_HAS_UBSAN FALSE)
	endif()			endif()

	if (COMPILER_RT_HAS_SANITIZER_COMMON AND SAFESTACK_SUPPORTED_ARCH AND			if (COMPILER_RT_HAS_SANITIZER_COMMON AND SAFESTACK_SUPPORTED_ARCH AND
	OS_NAME MATCHES "Darwin\|Linux\|FreeBSD")			OS_NAME MATCHES "Darwin\|Linux\|FreeBSD")
	set(COMPILER_RT_HAS_SAFESTACK TRUE)			set(COMPILER_RT_HAS_SAFESTACK TRUE)
	Show All 31 Lines