Page MenuHomePhabricator

[MemorySSA] NFC small fixes
ClosedPublic

Authored by Prazek on Feb 17 2017, 11:40 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

Prazek created this revision.Feb 17 2017, 11:40 AM
davide accepted this revision.Feb 17 2017, 3:15 PM

You can probably on and commit a subset of this. I'm in doubt about the first chunk so I asked Danny/George to take a look.

lib/Transforms/Utils/MemorySSA.cpp
1324–1335 ↗(On Diff #88935)

hmm, this is probably correct but there's something that doesn't really convinces me about it, I'll let Danny/George to sign-off on this part of the patch.

1453–1461 ↗(On Diff #88935)

This is obviously dead code, so I'm fine with this part of the patch.,

1462 ↗(On Diff #88935)

Nice comment.

This revision is now accepted and ready to land.Feb 17 2017, 3:15 PM

LGTM with one nit. Thanks for the patch!

lib/Transforms/Utils/MemorySSA.cpp
1327 ↗(On Diff #88935)

Nit: Indent the " to under the !, please

Prazek marked an inline comment as done.Feb 18 2017, 12:21 PM
Prazek added inline comments.
lib/Transforms/Utils/MemorySSA.cpp
1462 ↗(On Diff #88935)

Thanks, I actually moved it from top of the function :)

This revision was automatically updated to reflect the committed changes.