Page MenuHomePhabricator

Create msbuild only when using MSVC
ClosedPublic

Authored by mati865 on Feb 14 2017, 11:29 AM.

Details

Summary

I could be wrong but it seems to have no use for MinGW.

Related diff: https://reviews.llvm.org/D29772

Diff Detail

Repository
rL LLVM

Event Timeline

mati865 created this revision.Feb 14 2017, 11:29 AM
rnk accepted this revision.Feb 14 2017, 11:36 AM
rnk added a subscriber: rnk.

Seems reasonable. You might want to investigate if things go wrong if you try to package an NSIS installer of clang that targets mingw. Right now it will probably attempt to install these files into ProgFiles/MSBuild, and that will likely fail with this change.

This revision is now accepted and ready to land.Feb 14 2017, 11:36 AM

That's valid concern, I'll try tomorrow to find out how it works.

P.S.
The only reason of this patch is tools/msbuild doesn't look nice with Filesystem Hierarchy Standard adopted by MSYS2 and wastes some space (copy instead of symlink).

I suppose those 4 lines were your concern: https://github.com/llvm-mirror/llvm/blob/3ca564103abdd0c70f28f270873a2e535c245a6f/CMakeLists.txt#L231

I ran make package in the build dir patched with this diff and https://reviews.llvm.org/D29772 and it returned no errors.
Install and uninstall of created package was also successful.

This revision was automatically updated to reflect the committed changes.

Thank you @rnk
Could you check https://reviews.llvm.org/D29772 ? Looks like there was problem with commit