Daily report: display the number of tests seen near the top of the report, rather than at the bottom.

[aadg]

Summary

The usual process when looking at the daily report page is:

1. Look at which builder submitted (or not) results,
2. Look at the number of tests submitted by each builder,
3. Look at the actual regressions' details, scrolling down the page as necessary.

This commit make the daily report layout follow the logical process.

This is a useability change and functionality is not affected.

[kristof.beyls]

I also think this is an improvement.
Probably best to hear from Chris M to see if he thinks so too.

Thanks Arnaud!

[cmatthews]

Sure.

lnt/trunk/lnt/server/ui/templates/reporting/daily_report.html

<tr class="searchable">
       <td style="{{ styles.td }}; background-color:#FF0000">N/A</td>
 {%-   endif -%}
 {%- endfor %}
     </tr>
 {% endfor %}
   </tbody>
 </table>
 
+<h3>Number of Tests Seen</h3>
+<table border="1" style="{{ styles.table }}; width: {{
+                            400 + report.num_prior_days_to_include*80}}px;">
+  <thead>
+    <tr>
+      <th style="{{ styles.th }}; width: 300px;">Machine Name</th>
+    {% for i in range(report.num_prior_days_to_include)|reverse %}
+      <th style="{{ styles.th }}">Day - {{i}}</th>
+    {% endfor %}
+    </tr>
+  </thead>
+  <tbody>
+  {% for machine, nr_tests_for_machine in report.nr_tests_table %}
+  <tr class="searchable">
+    <td class="machine-name" style="{{ styles.td }}">{{machine.name}}</td>
+    {% set nr_tests_prev = None %}
+    {% for nr_tests in nr_tests_for_machine|reverse %}
+        <td style="{{ styles.td }}"
+        {%- if nr_tests_prev is not none and nr_tests_prev != nr_tests %}
+            bgcolor="#dfaf5f"
+        {% endif -%}
+            >{{nr_tests}}</td>
+        {% set nr_tests_prev = nr_tests %}
+    {% endfor %}
+  </tr>
+  {% endfor %}
+  </tbody>
+</table>
+
 {% macro get_initial_cell_value(day_result) %}
 {%- set cr = day_result.cr -%}
 {%- set test_status = cr.get_test_status() -%}
 
 {%- if (test_status == analysis.REGRESSED or
        test_status == analysis.UNCHANGED_FAIL) %}
     <td style="{{ styles.td }}; background-color:#e98080">FAIL</td>
 {%- else %}
<tr class="searchable">
     <td>{{ spark_plot(day_results) }}</td>
   </tr>
 {%-  endfor %}
 {{ "</tbody></table><p>" if report.for_mail }}
 {%- endfor %}
 {{ "</tbody></table>" if not report.for_mail }}
 {%- endfor -%}
 
-<h3>Number of Tests Seen</h3>
-<table border="1" style="{{ styles.table }}; width: {{
-                            400 + report.num_prior_days_to_include*80}}px;">
-  <thead>
-    <tr>
-      <th style="{{ styles.th }}; width: 300px;">Machine Name</th>
-    {% for i in range(report.num_prior_days_to_include)|reverse %}
-      <th style="{{ styles.th }}">Day - {{i}}</th>
-    {% endfor %}
-    </tr>
-  </thead>
-  <tbody>
-  {% for machine, nr_tests_for_machine in report.nr_tests_table %}
-  <tr class="searchable">
-    <td class="machine-name" style="{{ styles.td }}">{{machine.name}}</td>
-    {% set nr_tests_prev = None %}
-    {% for nr_tests in nr_tests_for_machine|reverse %}
-        <td style="{{ styles.td }}"
-        {%- if nr_tests_prev is not none and nr_tests_prev != nr_tests %}
-            bgcolor="#dfaf5f"
-        {% endif -%}
-            >{{nr_tests}}</td>
-        {% set nr_tests_prev = nr_tests %}
-    {% endfor %}
-  </tr>
-  {% endfor %}
-  </tbody>
-</table>
-
 {% endif %}
 
 {% if not only_html_body %}
 </body>
 </html>
 {% endif %}