This is an archive of the discontinued LLVM Phabricator instance.

FunctionAttrs: Factor out a function for querying memory access of a specific copy of a function. NFC.
ClosedPublic

Authored by pcc on Feb 7 2017, 5:16 PM.

Details

Event Timeline

pcc created this revision.Feb 7 2017, 5:16 PM
tejohnson added inline comments.
llvm/lib/Transforms/IPO/FunctionAttrs.cpp
55

Why don't we want to check this in the callers of computeFunctionBodyMemoryAccess? Isn't it a strong guarantee?

pcc updated this revision to Diff 88253.Feb 13 2017, 1:50 PM
  • Address review comments
pcc added inline comments.Feb 13 2017, 1:50 PM
llvm/lib/Transforms/IPO/FunctionAttrs.cpp
55

Yes, we could (and that would let us simplify the caller in D29803 a little). I've uploaded a new patch that does that, and also simplifies the signature of computeFunctionBodyMemoryAccess a little by removing the SCCNodeSet, as we currently have no plans to call that function from an SCC pass.

tejohnson accepted this revision.Feb 13 2017, 2:03 PM
tejohnson added inline comments.
llvm/lib/Transforms/IPO/FunctionAttrs.cpp
52

Document options (specifically the new ThisBody needs some comment).

This revision is now accepted and ready to land.Feb 13 2017, 2:03 PM

LGTM with comment as suggested

This revision was automatically updated to reflect the committed changes.