This is an archive of the discontinued LLVM Phabricator instance.

Differential D29549

[libFuzzer] Change Uninstrumented test name.
ClosedPublic

Authored by mpividori on Feb 4 2017, 2:36 PM.

Details

Reviewers
kcc
zturner
Commits
rGe219d401912f: [libFuzzer] Change Uninstrumented test name.
rL294387: [libFuzzer] Change Uninstrumented test name.
Summary

On Windows, executables with the word "uninst" included their name are associated with administrator privileges. Probably they are associated with uninstallers.

Diff Detail

Event Timeline

mpividori created this revision.Feb 4 2017, 2:36 PM
Herald added a subscriber: mgorny. · View Herald TranscriptFeb 4 2017, 2:36 PM
kcc accepted this revision.Feb 6 2017, 11:06 AM

LGTM
Maybe NotInstrumented ?

This revision is now accepted and ready to land.Feb 6 2017, 11:06 AM
mpividori added a comment.Feb 6 2017, 11:42 AM

@kcc Ok. I will use NotInstrumented.

Closed by commit rL294387: [libFuzzer] Change Uninstrumented test name. (authored by mpividori). · Explain WhyFeb 7 2017, 4:14 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
lib/
Fuzzer/
test/
NoinstrumentedTest.cpp
UninstrumentedTest.cpp
2 lines
no-coverage/
2 lines

Diff 87113

lib/Fuzzer/test/NoinstrumentedTest.cpp

  • This file was moved from lib/Fuzzer/test/UninstrumentedTest.cpp.
The contents of this file were not changed.

lib/Fuzzer/test/UninstrumentedTest.cpp

  • This file was moved to lib/Fuzzer/test/NoinstrumentedTest.cpp.

lib/Fuzzer/test/fuzzer.test

Show All 28 Lines
COUNTERS: NEW {{.*}} {{bits:|ft:}} {{[1-9]*}} COUNTERS: NEW {{.*}} {{bits:|ft:}} {{[1-9]*}}
COUNTERS: NEW {{.*}} {{bits:|ft:}} {{[1-9]*}} COUNTERS: NEW {{.*}} {{bits:|ft:}} {{[1-9]*}}
COUNTERS: BINGO COUNTERS: BINGO
# Don't run UninstrumentedTest for now since we build libFuzzer itself with asan. # Don't run UninstrumentedTest for now since we build libFuzzer itself with asan.
DISABLED: not LLVMFuzzer-UninstrumentedTest-Uninstrumented 2>&1 | FileCheck %s --check-prefix=UNINSTRUMENTED DISABLED: not LLVMFuzzer-UninstrumentedTest-Uninstrumented 2>&1 | FileCheck %s --check-prefix=UNINSTRUMENTED
UNINSTRUMENTED: ERROR: __sanitizer_set_death_callback is not defined. Exiting. UNINSTRUMENTED: ERROR: __sanitizer_set_death_callback is not defined. Exiting.
RUN: not LLVMFuzzer-UninstrumentedTest-NoCoverage 2>&1 | FileCheck %s --check-prefix=NO_COVERAGE RUN: not LLVMFuzzer-NoinstrumentedTest-NoCoverage 2>&1 | FileCheck %s --check-prefix=NO_COVERAGE
NO_COVERAGE: ERROR: no interesting inputs were found. Is the code instrumented for coverage? Exiting NO_COVERAGE: ERROR: no interesting inputs were found. Is the code instrumented for coverage? Exiting
RUN: not LLVMFuzzer-BufferOverflowOnInput 2>&1 | FileCheck %s --check-prefix=OOB RUN: not LLVMFuzzer-BufferOverflowOnInput 2>&1 | FileCheck %s --check-prefix=OOB
OOB: AddressSanitizer: heap-buffer-overflow OOB: AddressSanitizer: heap-buffer-overflow
OOB: is located 0 bytes to the right of 3-byte region OOB: is located 0 bytes to the right of 3-byte region
RUN: not LLVMFuzzer-InitializeTest -use_value_profile=1 2>&1 | FileCheck %s RUN: not LLVMFuzzer-InitializeTest -use_value_profile=1 2>&1 | FileCheck %s
Show All 15 Lines

lib/Fuzzer/test/no-coverage/CMakeLists.txt

# These tests are not instrumented with coverage, # These tests are not instrumented with coverage,
# but have coverage rt in the binary. # but have coverage rt in the binary.
set(CMAKE_CXX_FLAGS set(CMAKE_CXX_FLAGS
"${LIBFUZZER_FLAGS_BASE} -fno-sanitize-coverage=edge,trace-cmp,indirect-calls,8bit-counters,trace-pc-guard") "${LIBFUZZER_FLAGS_BASE} -fno-sanitize-coverage=edge,trace-cmp,indirect-calls,8bit-counters,trace-pc-guard")
set(NoCoverageTests set(NoCoverageTests
UninstrumentedTest NoinstrumentedTest
) )
foreach(Test ${NoCoverageTests}) foreach(Test ${NoCoverageTests})
add_libfuzzer_test(${Test}-NoCoverage SOURCES ../${Test}.cpp) add_libfuzzer_test(${Test}-NoCoverage SOURCES ../${Test}.cpp)
endforeach() endforeach()
############################################################################### ###############################################################################
Show All 14 Lines