[ARM] const cast fix for ARMAttributeParser test

[samparker]

Summary

GCC 4.8 produced a cast qualifier warning.

[rengolin]

unittests/Support/ARMAttributeParser.cpp

34–35

Weird, the template type is not const...

then, shouldn't this be:

ArrayRef<const uint8_t> Bytes((const uint8_t*)OS.str().c_str(), OS.str().size());

or why can't it just be const char?

[rengolin]

It helps reading the warning message :)

../unittests/Support/ARMAttributeParser.cpp: In function ‘bool testBuildAttr(unsigned int, unsigned int, unsigned int, unsigned int)’:
../unittests/Support/ARMAttributeParser.cpp:34:52: warning: cast from type ‘const char*’ to type ‘uint8_t* {aka unsigned char*}’ casts away qualifiers [-Wcast-qual]
   ArrayRef<uint8_t> Bytes((uint8_t*)OS.str().c_str(), OS.str().size());

[samparker]

The AttributeParser::Parse was defined as accepting an ArrayRef<uint8_t> so I just stuck to this. Also, the template type does not need to be const since ArrayRef always uses the type to create a const pointer from it.

[rovka]

Maybe I'm being a bit pedantic here, but while we're at it, could we also switch to a C++ cast instead of the C-style cast?

[rengolin]

In D29380#662892, @samparker wrote:

The AttributeParser::Parse was defined as accepting an ArrayRef<uint8_t> so I just stuck to this. Also, the template type does not need to be const since ArrayRef always uses the type to create a const pointer from it.

Good point.

[samparker]

Using reinterpret cast for c++ style, including the const qualifier.

[rovka]

LGTM

[samparker]

ah, I didn't see your last message and I've already committed! I will manually close this once it is accepted.

[rengolin]

That's ok, this can be a post-commit review.

[samparker]

Closed with commit rL293764

unittests/Support/ARMAttributeParser.cpp

void write(raw_ostream &OS) {
     OS << "aeabi" << '\0';
     OS << (uint8_t)1 << (uint8_t)7 << (uint8_t)0 << (uint8_t)0 << (uint8_t)0;
     OS << (uint8_t)Tag << (uint8_t)Value;
 
   }
 };
 
 bool testBuildAttr(unsigned Tag, unsigned Value,
-                      unsigned ExpectedTag, unsigned ExpectedValue) {
   std::string buffer;
   raw_string_ostream OS(buffer);
   AttributeSection Section(Tag, Value);
   Section.write(OS);
-  ArrayRef<uint8_t> Bytes((uint8_t*)OS.str().c_str(), OS.str().size());
+  ArrayRef<uint8_t> Bytes(
+    reinterpret_cast<const uint8_t*>(OS.str().c_str()), OS.str().size());
 
   ARMAttributeParser Parser;
   Parser.Parse(Bytes, true);
 
   return (Parser.hasAttribute(ExpectedTag) &&
     Parser.getAttributeValue(ExpectedTag) == ExpectedValue);
 }