This allows clients of the LTO API to determine the name of the fallback symbol for COFF weak externals.
|149 ↗||(On Diff #86559)|
I'd make this function specifically for COFF weak externals. No other format requires this feature during symbol resolution, as far as I know.
|150 ↗||(On Diff #86559)|
|152 ↗||(On Diff #86559)|
Maybe assert that the symbol is a weak external?
|154 ↗||(On Diff #86559)|
This could be a bitcast or a gep, so I think you need to call stripPointerCasts on the result. You also need to mangle the symbol name, see how we set Name for example.
|156 ↗||(On Diff #86559)|
I don't think we can get here if the symbol is a valid weak external. I'd assert (via cast or otherwise) that this is the case.