[sanitizer] Support SANITIZER_INTERCEPTOR_HOOKS on Darwin

[bogner]

Summary

This basically already worked other than weak symbols needing definitions on darwin.

[kcc]

please move sanitizer_common/TestCases/Linux/weak_hook_test.cc to ./sanitizer_common/TestCases/Posix/
and make sure that it works (and fails w/o you change)

[bogner]

Moved the weak_hook_test to run for all posix platforms

[kcc]

lib/sanitizer_common/sanitizer_common_interceptors.inc

49

Why did you remove the 'if'?

[bogner]

lib/sanitizer_common/sanitizer_common_interceptors.inc

49

SANITIZER_INTERFACE_WEAK_DEF defines an empty default definition, so it would always be true.

[kcc]

LGTM, please watch the bots.

[bogner]

Committed in r293741.

lib/sanitizer_common/sanitizer_common_interceptors.inc

 #include <stdarg.h>
 
 #if SANITIZER_INTERCEPTOR_HOOKS
-#define CALL_WEAK_INTERCEPTOR_HOOK(f, ...)                                     \
-  do {                                                                         \
-    if (f)                                                                     \
-      f(__VA_ARGS__);                                                          \
-  } while (false);
-#define DECLARE_WEAK_INTERCEPTOR_HOOK(f, ...)                                  \
-  extern "C" {                                                                 \
-  SANITIZER_INTERFACE_ATTRIBUTE SANITIZER_WEAK_ATTRIBUTE void f(__VA_ARGS__);  \
-  } // extern "C"
+#define CALL_WEAK_INTERCEPTOR_HOOK(f, ...) f(__VA_ARGS__);
+#define DECLARE_WEAK_INTERCEPTOR_HOOK(f, ...) \
+  SANITIZER_INTERFACE_WEAK_DEF(void, f, __VA_ARGS__) {}
 #else
 #define DECLARE_WEAK_INTERCEPTOR_HOOK(f, ...)
 #define CALL_WEAK_INTERCEPTOR_HOOK(f, ...)

lib/sanitizer_common/sanitizer_platform_interceptors.h

 #define SANITIZER_INTERCEPT_CTERMID SI_LINUX || SI_MAC || SI_FREEBSD
 #define SANITIZER_INTERCEPT_CTERMID_R SI_MAC || SI_FREEBSD
 
-#define SANITIZER_INTERCEPTOR_HOOKS SI_LINUX
+#define SANITIZER_INTERCEPTOR_HOOKS SI_LINUX || SI_MAC
 #define SANITIZER_INTERCEPT_RECV_RECVFROM SI_NOT_WINDOWS
 #define SANITIZER_INTERCEPT_SEND_SENDTO SI_NOT_WINDOWS
 #define SANITIZER_INTERCEPT_EVENTFD_READ_WRITE SI_LINUX