Page MenuHomePhabricator

[sanitizer] Support SANITIZER_INTERCEPTOR_HOOKS on Darwin
ClosedPublic

Authored by bogner on Jan 31 2017, 3:40 PM.

Details

Summary

This basically already worked other than weak symbols needing definitions on darwin.

Diff Detail

Event Timeline

bogner created this revision.Jan 31 2017, 3:40 PM
kcc edited edge metadata.Jan 31 2017, 3:42 PM

please move sanitizer_common/TestCases/Linux/weak_hook_test.cc to ./sanitizer_common/TestCases/Posix/
and make sure that it works (and fails w/o you change)

bogner updated this revision to Diff 86523.Jan 31 2017, 4:41 PM

Moved the weak_hook_test to run for all posix platforms

kcc added inline comments.Jan 31 2017, 4:50 PM
lib/sanitizer_common/sanitizer_common_interceptors.inc
49

Why did you remove the 'if'?

bogner added inline comments.Jan 31 2017, 5:09 PM
lib/sanitizer_common/sanitizer_common_interceptors.inc
49

SANITIZER_INTERFACE_WEAK_DEF defines an empty default definition, so it would always be true.

kcc accepted this revision.Jan 31 2017, 5:11 PM

LGTM, please watch the bots.

This revision is now accepted and ready to land.Jan 31 2017, 5:11 PM
bogner closed this revision.Jan 31 2017, 7:59 PM

Committed in r293741.