Page MenuHomePhabricator

[asan] Support handle_sigfpe on Darwin
ClosedPublic

Authored by bogner on Jan 31 2017, 3:38 PM.

Details

Diff Detail

Event Timeline

bogner created this revision.Jan 31 2017, 3:38 PM
kcc edited edge metadata.Jan 31 2017, 3:40 PM

test?

kubamracek edited edge metadata.Jan 31 2017, 3:56 PM

Sounds like the TestCases/Linux/fpe.cc could be just moved one directory up.

kcc added a comment.Jan 31 2017, 3:59 PM

Sounds like the TestCases/Linux/fpe.cc could be just moved one directory up.

Almost.
Don't forget there are platforms other than Linux and OSX.
So we'll also need a REQUIRES lines or something.

Right. I meant the Posix/ subdirectory, assuming this is okay on FreeBSD (which it should be, because sanitizer_linux.cc is also used on BSD).

bogner updated this revision to Diff 86527.Jan 31 2017, 5:15 PM

Move fpe test from Linux to Posix

kcc accepted this revision.Jan 31 2017, 5:38 PM

LGTM
please watch the bots (there are other Posix OSes out there).

This revision is now accepted and ready to land.Jan 31 2017, 5:38 PM
bogner closed this revision.Feb 1 2017, 12:10 AM

r293746