This is an archive of the discontinued LLVM Phabricator instance.

[sanitizer] Re-enable -fno-function-sections for powerpc64le
ClosedPublic

Authored by cryptoad on Jan 30 2017, 8:52 AM.

Details

Summary

For a reason that hasn't been investigated for lack of powerpc knowledge and
hardware, -fno-function-sections is required for the Sanitizers to work
properly on powerpc64le. Without, the function-sections-are-bad test fails on
that architecture (and that architecture only).

This patch re-enables the flag in the powerpc64le cflags.

I have to admit I am not entirely sure if my way is the proper way to do this,
so if anyone has a better way, I'll be happy to oblige.

Event Timeline

cryptoad created this revision.Jan 30 2017, 8:52 AM
eugenis accepted this revision.Jan 30 2017, 2:00 PM

This looks OK.
Please mention the test that is failing and the error message either in the comment or in the commit message.

This revision is now accepted and ready to land.Jan 30 2017, 2:01 PM
cryptoad updated this revision to Diff 86352.Jan 30 2017, 2:33 PM

Updating the comment to include the failing test and error message.

cryptoad closed this revision.Jan 30 2017, 2:43 PM