This is an archive of the discontinued LLVM Phabricator instance.

[sanitizer] Remove -fno-function-sections from SANITIZER_COMMON_CFLAGS
ClosedPublic

Authored by cryptoad on Jan 25 2017, 10:00 AM.

Details

Summary

-fno-function-sections was added as a default Sanitizer common cflag with
https://reviews.llvm.org/rL200683, the reasoning behind was that things would
break if linked with --gc-sections.

This appears to not be necessary anymore, as tests pass without, including
function-sections-are-bad.cc. There is a large benefit to having
function-sections when dealing with static libraries in terms of size and
dependencies that go away with --gc-sections.

Event Timeline

cryptoad created this revision.Jan 25 2017, 10:00 AM
eugenis accepted this revision.Jan 26 2017, 2:52 PM

LGTM

This revision is now accepted and ready to land.Jan 26 2017, 2:52 PM
cryptoad closed this revision.Jan 26 2017, 3:01 PM