Page MenuHomePhabricator

AMDGPU/SI: Move some ISel helpers into utils so they can be shared with GISel
ClosedPublic

Authored by tstellarAMD on Jan 23 2017, 7:06 PM.

Diff Detail

Repository
rL LLVM

Event Timeline

arsenm accepted this revision.Jan 23 2017, 7:13 PM

LGTM

lib/Target/AMDGPU/SIInstrInfo.cpp
2536–2550 ↗(On Diff #85516)

These are trivial enough to go in the header

This revision is now accepted and ready to land.Jan 23 2017, 7:13 PM
lib/Target/AMDGPU/SIInstrInfo.cpp
2536–2550 ↗(On Diff #85516)

I tried this, but it would require including AMDGPUSubtarget.h in SIInstrInfo.h which creates a circular header dependency.

arsenm added inline comments.Jan 24 2017, 7:18 PM
lib/Target/AMDGPU/SIInstrInfo.cpp
2536–2550 ↗(On Diff #85516)

It would also make sense to mote into AMDGPUBaseInfo since it is encoding related

This revision was automatically updated to reflect the committed changes.