This is an archive of the discontinued LLVM Phabricator instance.

Differential D29043

[Lanai] Rename LanaiInstPrinter library to LanaiAsmPrinter
ClosedPublic

Authored by beanz on Jan 23 2017, 11:32 AM.

Details

Reviewers
jpienaar
bryant
Commits
rGbef847c3ae3a: [Lanai] Rename LanaiInstPrinter library to LanaiAsmPrinter
rL292953: [Lanai] Rename LanaiInstPrinter library to LanaiAsmPrinter
Summary
This is in keeping with LLVM convention. The classes are InstPrinters, but the library is ${target}AsmPrinter.

Diff Detail

Event Timeline

beanz created this revision.Jan 23 2017, 11:32 AM
Harbormaster completed remote builds in B3195: Diff 85436.Jan 23 2017, 11:32 AM
Herald added subscribers: • jgosnell, mgorny. · View Herald TranscriptJan 23 2017, 11:32 AM
bryant accepted this revision.Jan 23 2017, 2:21 PM

I thought that there'd be stuff to change in clang, compiler-rt, and libcxx, but nope. LGTM.

This revision is now accepted and ready to land.Jan 23 2017, 2:21 PM
jpienaar accepted this revision.Jan 24 2017, 7:56 AM

Thanks!

Closed by commit rL292953: [Lanai] Rename LanaiInstPrinter library to LanaiAsmPrinter (authored by cbieneman). · Explain WhyJan 24 2017, 9:38 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
lib/
Target/
Lanai/
InstPrinter/
2 lines
2 lines
2 lines
MCTargetDesc/
2 lines

Diff 85436

lib/Target/Lanai/InstPrinter/CMakeLists.txt

add_llvm_library(LLVMLanaiInstPrinter add_llvm_library(LLVMLanaiAsmPrinter
LanaiInstPrinter.cpp LanaiInstPrinter.cpp
) )

lib/Target/Lanai/InstPrinter/LLVMBuild.txt

Show All 11 Lines
; For more information on the LLVMBuild system, please see: ; For more information on the LLVMBuild system, please see:
; ;
; http://llvm.org/docs/LLVMBuild.html ; http://llvm.org/docs/LLVMBuild.html
; ;
;===------------------------------------------------------------------------===; ;===------------------------------------------------------------------------===;
[component_0] [component_0]
type = Library type = Library
name = LanaiInstPrinter name = LanaiAsmPrinter
parent = Lanai parent = Lanai
required_libraries = MC Support required_libraries = MC Support
add_to_library_groups = Lanai add_to_library_groups = Lanai

lib/Target/Lanai/LLVMBuild.txt

Show All 30 Lines
required_libraries = required_libraries =
Analysis Analysis
AsmPrinter AsmPrinter
CodeGen CodeGen
Core Core
LanaiAsmParser LanaiAsmParser
LanaiDesc LanaiDesc
LanaiInfo LanaiInfo
LanaiInstPrinter LanaiAsmPrinter
MC MC
SelectionDAG SelectionDAG
Support Support
Target Target
TransformUtils TransformUtils
add_to_library_groups = Lanai add_to_library_groups = Lanai

lib/Target/Lanai/MCTargetDesc/LLVMBuild.txt

Show All 13 Lines
; http://llvm.org/docs/LLVMBuild.html ; http://llvm.org/docs/LLVMBuild.html
; ;
;===------------------------------------------------------------------------===; ;===------------------------------------------------------------------------===;
[component_0] [component_0]
type = Library type = Library
name = LanaiDesc name = LanaiDesc
parent = Lanai parent = Lanai
required_libraries = LanaiInfo LanaiInstPrinter MC MCDisassembler Support required_libraries = LanaiInfo LanaiAsmPrinter MC MCDisassembler Support
add_to_library_groups = Lanai add_to_library_groups = Lanai