Page MenuHomePhabricator

Add some Book-E instructions to the asm parser and printer.
ClosedPublic

Authored by chmeee on Jan 22 2017, 8:25 PM.

Details

Diff Detail

Repository
rL LLVM

Event Timeline

chmeee created this revision.Jan 22 2017, 8:25 PM
chmeee added inline comments.Jan 22 2017, 8:33 PM
test/MC/Disassembler/PowerPC/ppc64-encoding-bookIII.txt
138 ↗(On Diff #85317)

Not sure if it's best to have these in this file, or the ...e500.txt file.

test/MC/PowerPC/ppc64-encoding-bookIII.s
200 ↗(On Diff #85317)

As above, not sure if this belongs here or in ...e500.s tests. They're defined in the ISA, but only for the embedded profile (Book-III E). Since they're defined in Book-III, I put them here.

hfinkel added inline comments.Jan 23 2017, 5:47 AM
test/MC/Disassembler/PowerPC/ppc64-encoding-bookIII.txt
138 ↗(On Diff #85317)

Only if they're specific to that processor line.

jhibbits added inline comments.
test/MC/Disassembler/PowerPC/ppc64-encoding-bookIII.txt
138 ↗(On Diff #85317)

We discussed on IRC, but relaying here for posterity:

These instructions, and some others in this file, are part of the Book-III/E profile. A follow-on change to this will rename the -e500 files to -bookIIIe, and move these and the others into those files.

This revision was automatically updated to reflect the committed changes.