Page MenuHomePhabricator

[lld/LTO] Add a flag to use the new PM during LTO
AbandonedPublic

Authored by davide on Jan 22 2017, 5:13 PM.

Details

Reviewers
chandlerc
ruiu
pcc
Summary

Depends on D28996 / D28997 , also needs a test.
Please hold on reviewing until the other two revisions go in.

Diff Detail

Event Timeline

davide created this revision.Jan 22 2017, 5:13 PM
chandlerc edited edge metadata.Jan 22 2017, 7:11 PM

FWIW, this looks good to me, but I don't know much about LLD so maybe wait for someone else to look... Or maybe you know enough to land this directly Davide, you've been working lots in this space.

ruiu edited edge metadata.Jan 23 2017, 10:11 AM

Is this flag intended to be a permanent flag, or is it going to be used during transition from old to new? If it is going to be used indefinitely, new in -lto-use-new-pm doesn't make much sense.

In D28998#653589, @ruiu wrote:

Is this flag intended to be a permanent flag, or is it going to be used during transition from old to new? If it is going to be used indefinitely, new in -lto-use-new-pm doesn't make much sense.

The hope is that once the new pass manager will be the default & baked for a bit, this flag will go away.

davide abandoned this revision.Jan 23 2017, 10:42 AM

Peter suggested we can use a cl::opt and therefore avoid teaching linkers about this. I think it's a good idea, so abandoning this for now.