[lld] Use %u instead of %d for uint32_t formatting

[hughbe]

Summary

StringTableOff is a uint32_t. However, here, we print it as a signed decimal (%d), which is wrong.

[joerg]

Neither is correct. It should be casted either to uintmax_t and printed with %ju or PRIu32 be used. The fancy new formatting system might also work of course, but won't give you a C string.
That said, this should also be changed to use snprintf...

[ruiu]

I'd probably just cast to unsigned long and use lu. Using sprintf with (size_t)COFF::NameSize is indeed better.

[ruiu]

LGTM

[hughbe]

Use snprintf

[hughbe]

I assume you made a typo in your comment @ruiu, and meant snprintf

Sorry for updating after you approved, I didn't notice!

[ruiu]

Still LGTM. Please run the tests and submit.

lld/trunk/COFF/Writer.cpp

   *Hdr = Header;
   if (StringTableOff) {
     // If name is too long, write offset into the string table as a name.
-    sprintf(Hdr->Name, "/%d", StringTableOff);
+    sprintf(Hdr->Name, "/%lu", static_cast<unsigned long>(StringTableOff));
   } else {
     assert(!Config->Debug || Name.size() <= COFF::NameSize);
     strncpy(Hdr->Name, Name.data(),