Page MenuHomePhabricator

hughbe (Hugh Bellamy)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 15 2016, 4:46 AM (185 w, 2 d)

Recent Activity

Mar 26 2017

hughbe updated the diff for D31372: Support Microsoft mangling of swift calling convention methods.
Mar 26 2017, 11:32 AM

Mar 25 2017

hughbe created D31372: Support Microsoft mangling of swift calling convention methods.
Mar 25 2017, 11:15 PM

Mar 17 2017

hughbe added a comment to D29889: Fix Microsoft Code Analysis warning in Allocator.h.

@Bigcheese sorry to keep bothering you. This file is transitively included in almost every place any Cpp project includes LLVM. This included Swift, which is where I found this warning.

Mar 17 2017, 7:47 PM
hughbe added a comment to D29890: Fix Microsoft Code Analysis warning in Hashing.h.

@chandlerc sorry to keep bothering you :D, didn't realise you were kinda important in the LLVM community when I submitted this so I'm sorry if I added the wrong person to review :) !

Mar 17 2017, 7:45 PM

Mar 15 2017

hughbe edited reviewers for D30926: Fix MSVC signed/unsigned conversion and size_t conversion warnings in LLDB, added: zturner; removed: jingham, hughbe.

As per discussion on lists

Mar 15 2017, 9:43 PM
hughbe edited reviewers for D30927: Normalize the LLVM cmake path before appending it to the module path, added: zturner; removed: beanz.

As per discussion on lists

Mar 15 2017, 9:43 PM · Restricted Project

Mar 13 2017

hughbe updated the diff for D30927: Normalize the LLVM cmake path before appending it to the module path.

Address feedback from Zachary Turner

Mar 13 2017, 9:59 PM · Restricted Project
hughbe accepted D30926: Fix MSVC signed/unsigned conversion and size_t conversion warnings in LLDB.
Mar 13 2017, 9:31 PM
hughbe updated the diff for D30926: Fix MSVC signed/unsigned conversion and size_t conversion warnings in LLDB.

Fix file names

Mar 13 2017, 9:11 PM
hughbe updated the diff for D30927: Normalize the LLVM cmake path before appending it to the module path.

Fix preview

Mar 13 2017, 9:09 PM · Restricted Project
hughbe created D30927: Normalize the LLVM cmake path before appending it to the module path.
Mar 13 2017, 9:08 PM · Restricted Project
hughbe created D30926: Fix MSVC signed/unsigned conversion and size_t conversion warnings in LLDB.
Mar 13 2017, 9:03 PM

Feb 23 2017

hughbe added a comment to D29889: Fix Microsoft Code Analysis warning in Allocator.h.

Friendly ping - hope I'm not wasting your time. I should also mention that very few malloc calls will need this, as this method is explicitly declared with LLVM_ATTRIBUTE_RETURNS_NONNULL

Feb 23 2017, 11:15 PM
hughbe added a comment to D29890: Fix Microsoft Code Analysis warning in Hashing.h.

Friendly ping :)

Feb 23 2017, 11:14 PM

Feb 22 2017

hughbe added a comment to D29880: Workaround MSVC bug when using TrailingObjects from a template..

Good to merge?

Feb 22 2017, 3:06 AM

Feb 17 2017

hughbe accepted D29880: Workaround MSVC bug when using TrailingObjects from a template..

Okay, considering this fixes the bug, I'm happy. Cheers, thanks for the fix! I'll make the necessary cherry-picking and upstream pulling to Swift

Feb 17 2017, 10:06 PM

Feb 13 2017

hughbe added a comment to D29890: Fix Microsoft Code Analysis warning in Hashing.h.

You're right - the code isn't clearer, however, the CA warning is fixed. The reason why I pushed for this change is that Hashing.h is a header file and is therefore included in most files that include something from "llvm/Support" or "llvm/ADT" etc.
This means that projects of mine that include LLVM's headers get hashing.h transitively (is that the right word?) imported. As such, when running code analysis on my own project, I get warnings from LLVM. Of course, these could easily be ignored, but worth fixing.

Feb 13 2017, 9:21 PM
hughbe added a comment to D29889: Fix Microsoft Code Analysis warning in Allocator.h.

Right - the reason why I'm pushing for this debug check in one place is because Allocator.h is a header. This means that it is included in almost all libraries that include anything from "llvm/Support" and "llvm/ADT" etc. etc.

Feb 13 2017, 9:19 PM
hughbe created D29890: Fix Microsoft Code Analysis warning in Hashing.h.
Feb 13 2017, 5:39 AM
hughbe added a reviewer for D29889: Fix Microsoft Code Analysis warning in Allocator.h: Bigcheese.
Feb 13 2017, 5:22 AM
hughbe created D29889: Fix Microsoft Code Analysis warning in Allocator.h.
Feb 13 2017, 5:20 AM
hughbe requested changes to D29880: Workaround MSVC bug when using TrailingObjects from a template..
Feb 13 2017, 4:28 AM
hughbe added a comment to D29880: Workaround MSVC bug when using TrailingObjects from a template..

Shoot, didn't mean to accept the revision, apologies

Feb 13 2017, 4:28 AM
hughbe accepted D29880: Workaround MSVC bug when using TrailingObjects from a template..

I'm sorry @jyknight

Feb 13 2017, 4:27 AM

Feb 12 2017

hughbe added a comment to D28991: [lld] Use %u instead of %d for uint32_t formatting.

I assume you made a typo in your comment @ruiu, and meant snprintf

Feb 12 2017, 10:36 PM · lld
hughbe updated the diff for D28991: [lld] Use %u instead of %d for uint32_t formatting.

Use snprintf

Feb 12 2017, 10:35 PM · lld
hughbe updated the diff for D28991: [lld] Use %u instead of %d for uint32_t formatting.
Feb 12 2017, 8:59 PM · lld
hughbe abandoned D29181: Make TrailingObjects private inheritance of TrailingObjectsImpl protected.

Your change looks much nicer - I'll handle updating apple/swift-llvm and apple/swift! Thanks

Feb 12 2017, 8:56 PM
hughbe added a comment to D29880: Workaround MSVC bug when using TrailingObjects from a template..

Nice - this is much cleaner than my attempt!

Feb 12 2017, 8:54 PM

Jan 27 2017

hughbe added a reviewer for D29181: Make TrailingObjects private inheritance of TrailingObjectsImpl protected: llvm-commits.
Jan 27 2017, 3:59 AM

Jan 26 2017

hughbe created D29181: Make TrailingObjects private inheritance of TrailingObjectsImpl protected.
Jan 26 2017, 8:16 AM

Jan 22 2017

hughbe updated the diff for D28991: [lld] Use %u instead of %d for uint32_t formatting.
Jan 22 2017, 11:45 AM · lld
hughbe updated the diff for D28991: [lld] Use %u instead of %d for uint32_t formatting.
Jan 22 2017, 11:43 AM · lld
hughbe updated the diff for D28991: [lld] Use %u instead of %d for uint32_t formatting.
Jan 22 2017, 11:41 AM · lld
hughbe created D28991: [lld] Use %u instead of %d for uint32_t formatting.
Jan 22 2017, 11:36 AM · lld

Nov 18 2016

hughbe abandoned D26847: Fix Internal Compiler Error compiling Clang with the latest version of MSVC.
Nov 18 2016, 6:35 AM
hughbe added a comment to D26847: Fix Internal Compiler Error compiling Clang with the latest version of MSVC.

Thanks Malcolm. You're right, my bad! Sorry for wasting your time

Nov 18 2016, 6:32 AM
hughbe retitled D26847: Fix Internal Compiler Error compiling Clang with the latest version of MSVC from to Fix Internal Compiler Error compiling Clang with the latest version of MSVC.
Nov 18 2016, 4:48 AM