This is an archive of the discontinued LLVM Phabricator instance.

Write the Named Stream Map and StringTable to yaml / binary
ClosedPublic

Authored by zturner on Jan 19 2017, 2:27 PM.

Details

Summary

This finishes getting the string table and named stream map written to binary PDB and round-tripping through YAML.

This should be everything we need to start producing PDBs with strings filled out in the string table.

Diff Detail

Event Timeline

zturner created this revision.Jan 19 2017, 2:27 PM
ruiu accepted this revision.Jan 19 2017, 2:33 PM

LGTM

llvm/tools/llvm-pdbdump/LLVMOutputStyle.cpp
474–478

You might want to define printString(const Twine &) so that you don't need to use SmallString like this.

This revision is now accepted and ready to land.Jan 19 2017, 2:33 PM
This revision was automatically updated to reflect the committed changes.