Page MenuHomePhabricator

[scudo] Replacing std::atomic with Sanitizer's atomics
ClosedPublic

Authored by cryptoad on Jan 18 2017, 9:37 AM.

Details

Summary

In an effort to getting rid of dependencies to external libraries, we are
replacing atomic PackedHeader use of std::atomic with Sanitizer's
atomic_uint64_t, which allows us to avoid -latomic.

Event Timeline

cryptoad created this revision.Jan 18 2017, 9:37 AM
cryptoad retitled this revision from [scudo] Replacing std::atomic with Sanitizer's atomic to [scudo] Replacing std::atomic with Sanitizer's atomics.Jan 18 2017, 9:38 AM
cryptoad added reviewers: kcc, phosek, alekseyshl.
cryptoad added a subscriber: llvm-commits.
phosek added inline comments.Jan 18 2017, 9:45 AM
test/scudo/lit.cfg
21–22

Is this still needed?

cryptoad added inline comments.Jan 18 2017, 10:17 AM
test/scudo/lit.cfg
21–22

I use std::vector and other things in the tests.
I could rewrite them and get rid of it, but malloc.cpp, realloc.cpp and interface.cpp need -lstdc++ in their current state.

cryptoad marked 2 inline comments as done.Jan 18 2017, 10:50 AM
cryptoad updated this revision to Diff 84861.Jan 18 2017, 10:51 AM

Making -lstdc++ explicit in tests that require it, thus allowing removal from
the general lit.cfg.

This revision is now accepted and ready to land.Jan 20 2017, 10:40 AM
cryptoad closed this revision.Jan 20 2017, 10:43 AM