This is an archive of the discontinued LLVM Phabricator instance.

Add a test case for LICM when promoting locals that may be read after the throw within the loop. NFCI.
ClosedPublic

Authored by trentxintong on Jan 17 2017, 1:00 PM.

Download Raw Diff

Details

Reviewers

eli.friedman
sanjoy
hfinkel

Commits

rG0bc297787485: Add a test case for LICM when promoting locals that may be read after the throw…
rL292261: Add a test case for LICM when promoting locals that may be read after the throw…

Summary

Add a test case for LICM when promoting locals that may be read after the throw within the loop.

Diff Detail

Build Status

Buildable 2997
Build 2997: arc lint + arc unit

Event Timeline

trentxintong created this revision.Jan 17 2017, 1:00 PM

Harbormaster completed remote builds in B2997: Diff 84725.Jan 17 2017, 1:00 PM

This has been mentioned https://reviews.llvm.org/D20944.

LGTM.

test/Transforms/LICM/scalar-promote-unwind.ll
75	Run-on sentence, and a little hard to understand in general. Maybe "In this test, a loop is within a try block. There is an explicit unwind edge out of the loop. Make sure this edge is treated as a loop exit, and that the loads and stores are promoted as expected."

Address comments.

Harbormaster completed remote builds in B3004: Diff 84740.Jan 17 2017, 1:37 PM

Closed by commit rL292261: Add a test case for LICM when promoting locals that may be read after the throw… (authored by trentxintong). · Explain WhyJan 17 2017, 1:37 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents

Path

Size

test/

Transforms/

LICM/

scalar-promote-unwind.ll

78 lines

Diff 84725

test/Transforms/LICM/scalar-promote-unwind.ll

Show First 20 Lines • Show All 63 Lines • ▼ Show 20 Lines	for.cond.cleanup:
ret void		ret void

; CHECK: define void @test2		; CHECK: define void @test2
; CHECK: store i32		; CHECK: store i32
; CHECK-NEXT: ret void		; CHECK-NEXT: ret void
ret void		ret void
}		}

		@_ZTIi = external constant i8*

		; This is a test which the loop is within a try block, we must make sure that there is the explicit
		; unwind edge out of the loop due to the fact that boo() may throw and its treated as a loop exit.
		efriedmaUnsubmitted Not Done Reply Inline Actions Run-on sentence, and a little hard to understand in general. Maybe "In this test, a loop is within a try block. There is an explicit unwind edge out of the loop. Make sure this edge is treated as a loop exit, and that the loads and stores are promoted as expected." efriedma: Run-on sentence, and a little hard to understand in general. Maybe "In this test, a loop is…
		; And that loads/stores are promoted as expected.
		define void @loop_within_tryblock() personality i8* bitcast (i32 (...)* @__gxx_personality_v0 to i8*) {
		entry:
		%a = alloca i32, align 4
		store i32 0, i32* %a, align 4
		br label %for.cond

		for.cond:
		%i.0 = phi i32 [ 0, %entry ], [ %inc, %for.inc ]
		%cmp = icmp slt i32 %i.0, 1024
		br i1 %cmp, label %for.body, label %for.end

		; CHECK: for.body:
		; CHECK-NOT: load
		; CHECK-NOT: store
		; CHECK: invoke
		for.body:
		%0 = load i32, i32* %a, align 4
		%add = add nsw i32 %0, 1
		store i32 %add, i32* %a, align 4
		invoke void @boo()
		to label %invoke.cont unwind label %lpad

		invoke.cont:
		br label %for.inc

		for.inc:
		%inc = add nsw i32 %i.0, 1
		br label %for.cond

		; CHECK: lpad:
		; CHECK: store
		; CHECK: br
		lpad:
		%1 = landingpad { i8*, i32 }
		catch i8* bitcast (i8** @_ZTIi to i8*)
		%2 = extractvalue { i8*, i32 } %1, 0
		%3 = extractvalue { i8*, i32 } %1, 1
		br label %catch.dispatch

		catch.dispatch:
		%4 = call i32 @llvm.eh.typeid.for(i8* bitcast (i8** @_ZTIi to i8*)) #3
		%matches = icmp eq i32 %3, %4
		br i1 %matches, label %catch, label %eh.resume

		catch:
		%5 = call i8* @__cxa_begin_catch(i8* %2) #3
		%6 = bitcast i8* %5 to i32*
		%7 = load i32, i32* %6, align 4
		call void @__cxa_end_catch() #3
		br label %try.cont

		try.cont:
		ret void

		for.end:
		br label %try.cont

		eh.resume:
		%lpad.val = insertvalue { i8, i32 } undef, i8 %2, 0
		%lpad.val3 = insertvalue { i8*, i32 } %lpad.val, i32 %3, 1
		resume { i8*, i32 } %lpad.val3
		}

		declare void @boo()

		declare i32 @__gxx_personality_v0(...)

		declare i32 @llvm.eh.typeid.for(i8*)

		declare i8* @__cxa_begin_catch(i8*)

		declare void @__cxa_end_catch()

declare void @f() uwtable		declare void @f() uwtable