This is an archive of the discontinued LLVM Phabricator instance.

[PPC] Some generic cleanup of mayLoad/mayStore flags and memory operands
ClosedPublic

Authored by sfertile on Jan 17 2017, 11:20 AM.

Details

Summary

Another patch I am working on was querying the mayLoad and mayStore flags on machine SDNodes, as well as accessing the memory-operands of load instructions. I found a number of issues where the flags weren't set correctly, or the MachineSDNode was missing its memory operands. This patch addresses those issues.

  1. Explicitly sets mayLoad/mayStore property in the tablegen files on load/store instructions.
  2. Updated the flags on a number of intrinsics indicating that they write memory.
  3. Added SDNPMemOperand flags for some target dependent SDNodes so that they propagate their memory operand,

Diff Detail

Repository
rL LLVM

Event Timeline

sfertile created this revision.Jan 17 2017, 11:20 AM
sfertile updated this revision to Diff 84919.Jan 18 2017, 6:58 PM

Rebased patch to top of trunk, and updated a failing test.

hfinkel accepted this revision.Jan 24 2017, 8:43 AM

LGTM

This revision is now accepted and ready to land.Jan 24 2017, 8:43 AM
sfertile closed this revision.Jan 26 2017, 11:12 AM

Committed r293200