Page MenuHomePhabricator

Add -fstrict-vtable-pointers to UserManual
ClosedPublic

Authored by Prazek on Jan 14 2017, 2:10 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

Prazek updated this revision to Diff 84442.Jan 14 2017, 2:10 AM
Prazek retitled this revision from to Add -fstrict-vtable-pointers to UserManual.
Prazek updated this object.
Prazek added a reviewer: hans.
Prazek added a subscriber: cfe-commits.
hans edited edge metadata.Jan 14 2017, 1:20 PM

Would it be possible to expand on, or give some kind of pointer to, what "strict rules for overwriting polymorphic C++ objects" means?

Prazek updated this revision to Diff 84489.Jan 15 2017, 6:14 AM
Prazek edited edge metadata.

suggested fix

Prazek updated this revision to Diff 84492.Jan 15 2017, 6:26 AM

Removed [no-] so hyperlink would work

hans accepted this revision.Jan 15 2017, 4:22 PM
hans edited edge metadata.

lgtm with comment

docs/UsersManual.rst
1103 ↗(On Diff #84492)

e.g should be i.e. (or you could even spell it out: "that is")

I think it should also be "*the* vptr" and "*the* object* or "during an object's lifetime".

This revision is now accepted and ready to land.Jan 15 2017, 4:22 PM
This revision was automatically updated to reflect the committed changes.
Prazek marked an inline comment as done.

I also have sent it on the branch