Details
Details
Diff Detail
Diff Detail
- Repository
- rL LLVM
Event Timeline
lld/COFF/Chunks.h | ||
---|---|---|
190 ↗ | (On Diff #84413) | Maybe we should just make File public? |
lld/COFF/MapFile.cpp | ||
37 ↗ | (On Diff #84413) | It is unfortunate that you had to copy that much code, but honestly I have no good idea to avoid that because the code here is slightly different at a lot of places. |
67 ↗ | (On Diff #84413) | If you hard-code Width 8, please remove that variable and inline. |
lld/COFF/MapFile.cpp | ||
---|---|---|
37 ↗ | (On Diff #84413) | Right, the only real common part here is these 30 or so lines, and it didn't seem worth splitting that out into a library. |
Comment Actions
LGTM
lld/test/COFF/lldmap.test | ||
---|---|---|
10 ↗ | (On Diff #84420) | You want to remove / so that this test isn't picky about path separator difference. |