This is an archive of the discontinued LLVM Phabricator instance.

Fix UBSan bots by blacklisting bits/stl_tree.h.
ClosedPublic

Authored by krasin on Jan 13 2017, 9:32 AM.

Details

Summary

libstdc++ has some undefined behavior in bits/stl_tree.h that
has recently became excercised by some of the LLVM code.
Given that fixing libstdc++ will take years, adding the file
into a blacklist to fix bots seems like a necessity.

Event Timeline

krasin updated this revision to Diff 84326.Jan 13 2017, 9:32 AM
krasin retitled this revision from to Fix UBSan bots by blacklisting bits/stl_tree.h..
krasin updated this object.
krasin added a reviewer: vitalybuka.
krasin added a subscriber: llvm-commits.
krasin updated this revision to Diff 84327.Jan 13 2017, 9:33 AM

Remove leading space.

krasin updated this revision to Diff 84328.Jan 13 2017, 9:36 AM

Add a comment to the suppression.

This revision was automatically updated to reflect the committed changes.
vitalybuka reopened this revision.Jan 13 2017, 10:27 AM
vitalybuka accepted this revision.
vitalybuka edited edge metadata.
This revision is now accepted and ready to land.Jan 13 2017, 10:27 AM
vitalybuka closed this revision.Jan 13 2017, 10:27 AM