This is an archive of the discontinued LLVM Phabricator instance.

[CMake][libcxx] Do not rely on the existence of c++abi or unwind targets
ClosedPublic

Authored by phosek on Jan 5 2017, 5:40 PM.

Details

Summary

There is no guaranteed order in which CMake files for individual runtimes are invoked and therefore we cannot rely on existence of targets defined in other runtimes. Use the new HAVE_<name> options instead in those cases.

Diff Detail

Repository
rL LLVM

Event Timeline

phosek updated this revision to Diff 83331.Jan 5 2017, 5:40 PM
phosek retitled this revision from to [CMake][libcxx] Do not rely on the existence of c++abi or unwind targets.
phosek updated this object.
phosek added a reviewer: beanz.
phosek set the repository for this revision to rL LLVM.
phosek added a subscriber: llvm-commits.
beanz accepted this revision.Jan 9 2017, 3:56 PM
beanz edited edge metadata.

LGTM

This revision is now accepted and ready to land.Jan 9 2017, 3:56 PM
This revision was automatically updated to reflect the committed changes.