This is an archive of the discontinued LLVM Phabricator instance.

[Windows] Remove functions in intrin.h that are defined in Builtin.def.
ClosedPublic

Authored by jlebar on Jan 4 2017, 1:53 PM.

Details

Summary

These duplicate declarations cause a problem for CUDA compiles on
Windows. All implicitly-defined functions are host+device, and this
applies to the declarations in Builtin.def. But then when we see the
declarations in intrin.h, they have no attributes, so are host-only
functions. This is an error.

(A better fix might be to make these builtins host-only, but that is a
much bigger change.)

Diff Detail

Repository
rL LLVM

Event Timeline

jlebar updated this revision to Diff 83124.Jan 4 2017, 1:53 PM
jlebar retitled this revision from to [Windows] Remove functions in intrin.h that are defined in Builtin.def..
jlebar updated this object.
jlebar added a reviewer: rnk.
jlebar added subscribers: echristo, cfe-commits.
rnk accepted this revision.Jan 4 2017, 4:26 PM
rnk edited edge metadata.

lgtm

This revision is now accepted and ready to land.Jan 4 2017, 4:26 PM
This revision was automatically updated to reflect the committed changes.