This is an archive of the discontinued LLVM Phabricator instance.

Use TarWriter to create tar archives instead of cpio.
ClosedPublic

Authored by ruiu on Dec 25 2016, 12:44 AM.

Details

Summary

This is how we use TarWriter in LLD. Now LLD does not append
a file extension, so you need to pass --reproduce foo.tar
instead of --reproduce foo.

Event Timeline

ruiu updated this revision to Diff 82460.Dec 25 2016, 12:44 AM
ruiu retitled this revision from to Use TarWriter to create tar archives instead of cpio..
ruiu updated this object.
ruiu added reviewers: silvas, pcc, rafael.
ruiu added a subscriber: llvm-commits.
pcc added inline comments.Dec 25 2016, 1:51 AM
lld/COFF/Driver.cpp
27

Duplicate.

463

"repro.tar" here?

ruiu added inline comments.Dec 25 2016, 1:53 AM
lld/COFF/Driver.cpp
463

I think on Windows it is more natural to not specify a file extension, unlike Unix.

pcc added inline comments.Dec 25 2016, 2:11 AM
lld/COFF/Driver.cpp
463

I wasn't suggesting a functional change. /linkrepro takes a directory path to which you are appending repro here and .tar on lines 466 and 472, so you could just append repro.tar here.

ruiu updated this revision to Diff 82489.Dec 25 2016, 5:19 PM
  • Updated as per Peter's comment.
This revision was automatically updated to reflect the committed changes.