This is an archive of the discontinued LLVM Phabricator instance.

Replace WRAP in interceptors with memset, memmove and memcpy implementation
ClosedPublic

Authored by vitalybuka on Dec 21 2016, 4:35 PM.

Event Timeline

vitalybuka updated this revision to Diff 82288.Dec 21 2016, 4:35 PM
vitalybuka retitled this revision from to Replace WRAP in interceptors with memset, memmove and memcpy implementation.
vitalybuka updated this object.
vitalybuka added a reviewer: eugenis.
vitalybuka added a subscriber: llvm-commits.
vitalybuka updated this revision to Diff 82295.Dec 21 2016, 5:44 PM

fallback to msan or asan implementation if needed

eugenis accepted this revision.Dec 21 2016, 6:34 PM
eugenis edited edge metadata.
eugenis added inline comments.
lib/asan/asan_interceptors.cc
247

COMMON_INTERCEPTOR_MEMMOVE_IMPL

lib/msan/msan_interceptors.cc
1363–1364

now you can remove these undefs and switch both asan and msan to common interceptors, right?

This revision is now accepted and ready to land.Dec 21 2016, 6:34 PM
eugenis requested changes to this revision.Dec 21 2016, 6:34 PM
eugenis edited edge metadata.
This revision now requires changes to proceed.Dec 21 2016, 6:34 PM
vitalybuka marked 2 inline comments as done.Dec 21 2016, 6:45 PM
vitalybuka updated this revision to Diff 82302.Dec 21 2016, 6:49 PM
vitalybuka edited edge metadata.

cleanup

eugenis accepted this revision.Dec 22 2016, 1:17 PM
eugenis edited edge metadata.

LGTM

lib/msan/msan_interceptors.cc
49

why?

This revision is now accepted and ready to land.Dec 22 2016, 1:17 PM
vitalybuka added inline comments.Dec 22 2016, 2:11 PM
lib/msan/msan_interceptors.cc
49

Interceptors defined before inclusion of sanitizer_common_interceptors.inc need REAL(memset).
So we need either move include of sanitizer_common_interceptors.inc or declare here.

This revision was automatically updated to reflect the committed changes.