This is an archive of the discontinued LLVM Phabricator instance.

[ConstantFolding] Fix vector GEPs harder
ClosedPublic

Authored by mkuper on Dec 20 2016, 5:43 PM.

Details

Summary

CastGEPIndices still handles Vector GEPs incorrectly - in some cases we can fall into an infinite recursion, because we compare the vector type to the scalar pointer type, and then try to cast a type to itself.

Diff Detail

Event Timeline

mkuper updated this revision to Diff 82184.Dec 20 2016, 5:43 PM
mkuper retitled this revision from to [ConstantFolding] Fix vector GEPs harder.
mkuper updated this object.
mkuper added reviewers: davide, majnemer, loladiro.
mkuper added subscribers: llvm-commits, delena.
chandlerc accepted this revision.Dec 20 2016, 7:12 PM
chandlerc added a reviewer: chandlerc.
chandlerc added a subscriber: chandlerc.

LGTM, nice find.

This revision is now accepted and ready to land.Dec 20 2016, 7:12 PM
davide accepted this revision.Dec 21 2016, 2:00 AM
davide edited edge metadata.

LGTM.

This revision was automatically updated to reflect the committed changes.