This is an archive of the discontinued LLVM Phabricator instance.

Differential D27871

[libFuzzer] Remove AFL test on Windows.
AbandonedPublic

Authored by mpividori on Dec 16 2016, 4:18 PM.

Details

Reviewers
kcc
zturner

Diff Detail

Repository
rL LLVM

Event Timeline

mpividori updated this revision to Diff 81820.Dec 16 2016, 4:18 PM
mpividori retitled this revision from to [libFuzzer] Remove AFL test on Windows..
mpividori updated this object.
mpividori added reviewers: zturner, kcc.
mpividori set the repository for this revision to rL LLVM.
mpividori added a subscriber: llvm-commits.
Herald added a subscriber: mgorny. · View Herald TranscriptDec 16 2016, 4:18 PM
kcc added inline comments.Dec 16 2016, 4:20 PM
lib/Fuzzer/test/no-coverage/CMakeLists.txt
20

at the very least the comment is confusing.
If though AFL is not supported on windows, why should we disable this test? It does not actually use afl...

mpividori abandoned this revision.Dec 19 2016, 9:22 AM
mpividori added inline comments.
lib/Fuzzer/test/no-coverage/CMakeLists.txt
20

@kcc Yes, you are right. I disabled it because afl_driver was not ported yet. I will abandon this review, since I have updated afl_driver to work on Windows.

Revision Contents

PathSize
lib/
Fuzzer/
test/
no-coverage/
7 lines

Diff 81820

lib/Fuzzer/test/no-coverage/CMakeLists.txt

Show All 11 Linesforeach(Test ${NoCoverageTests})
add_libfuzzer_test(${Test}-NoCoverage SOURCES ../${Test}.cpp) add_libfuzzer_test(${Test}-NoCoverage SOURCES ../${Test}.cpp)
endforeach() endforeach()
############################################################################### ###############################################################################
# AFL Driver test # AFL Driver test
############################################################################### ###############################################################################
if(NOT MSVC)
kccUnsubmitted
Not Done
ReplyInline Actions

at the very least the comment is confusing.
If though AFL is not supported on windows, why should we disable this test? It does not actually use afl...

kcc: at the very least the comment is confusing. If though AFL is not supported on windows, why…
mpividoriAuthorUnsubmitted
Not Done
ReplyInline Actions

@kcc Yes, you are right. I disabled it because afl_driver was not ported yet. I will abandon this review, since I have updated afl_driver to work on Windows.

mpividori: @kcc Yes, you are right. I disabled it because afl_driver was not ported yet. I will abandon…
# AFL is not supported on Windows.
add_executable(AFLDriverTest add_executable(AFLDriverTest
../AFLDriverTest.cpp ../../afl/afl_driver.cpp) ../AFLDriverTest.cpp ../../afl/afl_driver.cpp)
endif()
set_target_properties(AFLDriverTest set_target_properties(AFLDriverTest
PROPERTIES RUNTIME_OUTPUT_DIRECTORY PROPERTIES RUNTIME_OUTPUT_DIRECTORY
"${CMAKE_BINARY_DIR}/lib/Fuzzer/test" "${CMAKE_BINARY_DIR}/lib/Fuzzer/test"
) )
# Propagate value into parent directory # Propagate value into parent directory
set(TestBinaries ${TestBinaries} AFLDriverTest PARENT_SCOPE) set(TestBinaries ${TestBinaries} AFLDriverTest PARENT_SCOPE)