Page MenuHomePhabricator

AMDGPU: Don't add same instruction multiple times to worklist
ClosedPublic

Authored by arsenm on Dec 16 2016, 2:42 PM.

Details

Reviewers
tstellarAMD
Summary

When the instruction is processed the first time, it may be
deleted resulting in crashes. While the new test adds the same
user to the worklist twice, this particular case doesn't crash
but I'm not sure why.

Diff Detail

Event Timeline

arsenm updated this revision to Diff 81800.Dec 16 2016, 2:42 PM
arsenm retitled this revision from to AMDGPU: Don't add same instruction multiple times to worklist.
arsenm updated this object.
arsenm added a subscriber: llvm-commits.
tstellarAMD accepted this revision.Dec 20 2016, 10:30 AM
tstellarAMD edited edge metadata.

LGTM.

This revision is now accepted and ready to land.Dec 20 2016, 10:30 AM
arsenm closed this revision.Dec 20 2016, 11:05 AM

r290191