The changes to <optional> LGTM but not the ones to <experimental/optional>
Unfortunately libc++'s <experimental/optional> doesn't yet implement LFTS v2 so all of the other non-const observers are also not constexpr in our implementation. I think updating <experimental/optional> to LFTS v2 should be done as a separate patch. Please back out the changes to <experimental/optional> before committing.
|48 ↗||(On Diff #82551)|
This test doesn't compile since the non-const version of std::experimental::optional::operator*() isn't constexpr.