This is an archive of the discontinued LLVM Phabricator instance.

[buildbot] switch CUDA buildbot to use CUDATestsuiteBuilder.
ClosedPublic

Authored by tra on Dec 14 2016, 1:25 PM.

Event Timeline

tra updated this revision to Diff 81450.Dec 14 2016, 1:25 PM
tra retitled this revision from to [buildbot] switch CUDA buildbot to use CUDATestsuiteBuilder..
tra updated this object.
tra added a reviewer: gkistanova.
tra added a subscriber: llvm-commits.
tra updated this revision to Diff 81453.Dec 14 2016, 1:27 PM

Do not rename the builder (yet).

gkistanova edited edge metadata.Dec 16 2016, 2:35 PM

Only changes in llvm and clang repo would trigger a build on this builder. Is this intentional?

tra added a comment.Dec 16 2016, 2:52 PM

Only changes in llvm and clang repo would trigger a build on this builder. Is this intentional?

Ideally the build should also be triggered for libcxx and test-suite changes, too, but I'm not sure how to configure that.
In practice llvm+clang changes trigger the builds often enough.

gkistanova requested changes to this revision.Jan 3 2017, 11:52 AM
gkistanova edited edge metadata.

The params there do not match what was committed for the factory.
Please check.

Thanks

Galina

This revision now requires changes to proceed.Jan 3 2017, 11:52 AM
tra updated this revision to Diff 82933.Jan 3 2017, 12:47 PM
tra edited edge metadata.

Removed obsolete getCUDATestsuiteBuildFactory() arguments.

tra added a comment.Jan 3 2017, 12:50 PM

The params there do not match what was committed for the factory.
Please check.

Sorry about that. I've updated the patch.

gkistanova accepted this revision.Jan 3 2017, 1:50 PM
gkistanova edited edge metadata.

LGTM

Thanks

Galina

This revision is now accepted and ready to land.Jan 3 2017, 1:50 PM
This revision was automatically updated to reflect the committed changes.