Page MenuHomePhabricator

File descriptor leaks on header files that contain errors
Needs ReviewPublic

Authored by JeanYves on Dec 14 2016, 10:24 AM.

Details

Reviewers
kfunk
Group Reviewers
Restricted Project
Summary

When using qtcreator, I remarked that there were some file descriptor leaks inside the clang lib.
On windows OS, it is quite annoying as some files cannot be saved.

I already posted a message on this matter earlier this year:
http://lists.llvm.org/pipermail/cfe-commits/Week-of-Mon-20151123/143910.html

Diff Detail

Repository
rL LLVM

Event Timeline

JeanYves updated this revision to Diff 81410.Dec 14 2016, 10:24 AM
JeanYves retitled this revision from to File descriptor leaks on header files that contain errors.
JeanYves updated this object.
JeanYves added a reviewer: Restricted Project.
JeanYves set the repository for this revision to rL LLVM.
JeanYves added a project: Restricted Project.
JeanYves added a subscriber: Restricted Project.
erikjv added a subscriber: erikjv.Dec 15 2016, 7:53 AM

That's actually working around the real problem, see https://reviews.llvm.org/D27810 . I'm also not sure if this is safe: if the memory buffer is mmap-backed, this could lead to some kind of use-after-free, because clang often uses StringRefs back into buffers in order to minimise string copies.

milianw added a subscriber: milianw.Jan 9 2018, 4:31 AM

Can this be abandoned now that the issue Erik has mentioned got fixed?