This is an archive of the discontinued LLVM Phabricator instance.

[sanitizer] Add workaround for empty strings
ClosedPublic

Authored by vitalybuka on Dec 8 2016, 8:58 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

vitalybuka updated this revision to Diff 80762.Dec 8 2016, 8:58 AM
vitalybuka retitled this revision from to [sanitizer] Add workaround for empty strings.
vitalybuka updated this object.
vitalybuka added a reviewer: eugenis.
vitalybuka added a subscriber: llvm-commits.
eugenis added inline comments.Dec 8 2016, 11:51 AM
lib/sanitizer_common/sanitizer_symbolizer_libcdep.cc
248 ↗(On Diff #80762)

Similarly to the next block,
if (last_colon && IsDigit(last_colon[1]))

vitalybuka updated this revision to Diff 80824.Dec 8 2016, 2:20 PM

simplified code

eugenis added inline comments.Dec 8 2016, 2:27 PM
lib/sanitizer_common/sanitizer_symbolizer_libcdep.cc
249 ↗(On Diff #80824)

handle the empty line case

vitalybuka updated this revision to Diff 80829.Dec 8 2016, 2:32 PM

handle empty strings

vitalybuka marked 2 inline comments as done.Dec 8 2016, 2:32 PM
eugenis accepted this revision.Dec 8 2016, 2:35 PM
eugenis edited edge metadata.

LGTM

This revision is now accepted and ready to land.Dec 8 2016, 2:35 PM
This revision was automatically updated to reflect the committed changes.