This is an archive of the discontinued LLVM Phabricator instance.

[sanitizer] Fix crash on empty strings.
ClosedPublic

Authored by vchigrin on Jan 26 2021, 3:06 AM.

Diff Detail

Event Timeline

vchigrin requested review of this revision.Jan 26 2021, 3:06 AM
vchigrin created this revision.
vchigrin added inline comments.Jan 26 2021, 3:12 AM
compiler-rt/lib/sanitizer_common/sanitizer_symbolizer_libcdep.cpp
360

After changes in https://reviews.llvm.org/D27574 AddressInfo::file field may be NULL here.

eugenis accepted this revision.Jan 26 2021, 12:56 PM

LGTM, thank you

This revision is now accepted and ready to land.Jan 26 2021, 12:56 PM

@eugenis - seems I don't have commit permission to llvm project. Could you commit this patch for me? I will be very grateful.
Thank you in advance!

This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptJan 27 2021, 1:09 PM
Herald added a subscriber: Restricted Project. · View Herald Transcript

@eugenis - seems I don't have commit permission to llvm project. Could you commit this patch for me? I will be very grateful.
Thank you in advance!

Now that we use Git, the new practice is to use git commit --amend --author= :) https://llvm.org/docs/DeveloperPolicy.html#commit-messages

Done. Too bad phab/arc does not do it automatically, and the email does not show up anywhere in the UI, too. It's such a bother to extract it from the mail headers.