This is an archive of the discontinued LLVM Phabricator instance.

Differential D27541

[libcxx] [test] Fix MSVC warning C4244 "conversion from 'X' to 'Y', possible loss of data", part 4/7.
ClosedPublic

Authored by STL_MSFT on Dec 7 2016, 2:02 PM.

Details

Reviewers
mclow.lists
EricWF
Summary

[libcxx] [test] Fix MSVC warning C4244 "conversion from 'X' to 'Y', possible loss of data", part 4/7.

Change char to long and remove some char casts. This preserves test coverage for tuple's
heterogeneous comparisons, while avoiding int-to-char truncation warnings.

Diff Detail

Event Timeline

STL_MSFT updated this revision to Diff 80655.Dec 7 2016, 2:02 PM
STL_MSFT retitled this revision from to [libcxx] [test] Fix MSVC warning C4244 "conversion from 'X' to 'Y', possible loss of data", part 4/7..
STL_MSFT updated this object.
STL_MSFT added reviewers: EricWF, mclow.lists.
STL_MSFT added a subscriber: cfe-commits.
Herald edited edge metadata. · View Herald TranscriptDec 7 2016, 2:02 PM
EricWF edited edge metadata.Dec 7 2016, 11:20 PM

Waiting for a response on D27540 before reviewing this.

STL_MSFT added a comment.Dec 8 2016, 12:43 PM

Responded to D27540. tuple is affected just like pair.

EricWF accepted this revision.Dec 8 2016, 12:44 PM
EricWF edited edge metadata.
This revision is now accepted and ready to land.Dec 8 2016, 12:44 PM
STL_MSFT mentioned this in rL289108: [libcxx] [test] Fix MSVC warning C4244 "conversion from 'X' to 'Y', possible….Dec 8 2016, 1:48 PM
STL_MSFT closed this revision.Dec 8 2016, 1:57 PM

Revision Contents

PathSize
test/
std/
utilities/
tuple/
tuple.tuple/
tuple.rel/
52 lines
58 lines

Diff 80655

test/std/utilities/tuple/tuple.tuple/tuple.rel/eq.pass.cpp

Show First 20 Lines • Show All 45 Lines • ▼ Show 20 Linesint main()
typedef std::tuple<double> T2; typedef std::tuple<double> T2;
const T1 t1(1); const T1 t1(1);
const T2 t2(1); const T2 t2(1);
assert(t1 == t2); assert(t1 == t2);
assert(!(t1 != t2)); assert(!(t1 != t2));
} }
{ {
typedef std::tuple<int, double> T1; typedef std::tuple<int, double> T1;
typedef std::tuple<double, char> T2; typedef std::tuple<double, long> T2;
const T1 t1(1, 2); const T1 t1(1, 2);
const T2 t2(1, char(2)); const T2 t2(1, 2);
assert(t1 == t2); assert(t1 == t2);
assert(!(t1 != t2)); assert(!(t1 != t2));
} }
{ {
typedef std::tuple<int, double> T1; typedef std::tuple<int, double> T1;
typedef std::tuple<double, char> T2; typedef std::tuple<double, long> T2;
const T1 t1(1, 2); const T1 t1(1, 2);
const T2 t2(1, char(3)); const T2 t2(1, 3);
assert(!(t1 == t2)); assert(!(t1 == t2));
assert(t1 != t2); assert(t1 != t2);
} }
{ {
typedef std::tuple<int, double> T1; typedef std::tuple<int, double> T1;
typedef std::tuple<double, char> T2; typedef std::tuple<double, long> T2;
const T1 t1(1, 2); const T1 t1(1, 2);
const T2 t2(1.1, char(2)); const T2 t2(1.1, 2);
assert(!(t1 == t2)); assert(!(t1 == t2));
assert(t1 != t2); assert(t1 != t2);
} }
{ {
typedef std::tuple<int, double> T1; typedef std::tuple<int, double> T1;
typedef std::tuple<double, char> T2; typedef std::tuple<double, long> T2;
const T1 t1(1, 2); const T1 t1(1, 2);
const T2 t2(1.1, char(3)); const T2 t2(1.1, 3);
assert(!(t1 == t2)); assert(!(t1 == t2));
assert(t1 != t2); assert(t1 != t2);
} }
{ {
typedef std::tuple<char, int, double> T1; typedef std::tuple<long, int, double> T1;
typedef std::tuple<double, char, int> T2; typedef std::tuple<double, long, int> T2;
const T1 t1(1, 2, 3); const T1 t1(1, 2, 3);
const T2 t2(1, 2, 3); const T2 t2(1, 2, 3);
assert(t1 == t2); assert(t1 == t2);
assert(!(t1 != t2)); assert(!(t1 != t2));
} }
{ {
typedef std::tuple<char, int, double> T1; typedef std::tuple<long, int, double> T1;
typedef std::tuple<double, char, int> T2; typedef std::tuple<double, long, int> T2;
const T1 t1(1, 2, 3); const T1 t1(1, 2, 3);
const T2 t2(1.1, 2, 3); const T2 t2(1.1, 2, 3);
assert(!(t1 == t2)); assert(!(t1 == t2));
assert(t1 != t2); assert(t1 != t2);
} }
{ {
typedef std::tuple<char, int, double> T1; typedef std::tuple<long, int, double> T1;
typedef std::tuple<double, char, int> T2; typedef std::tuple<double, long, int> T2;
const T1 t1(1, 2, 3); const T1 t1(1, 2, 3);
const T2 t2(1, 3, 3); const T2 t2(1, 3, 3);
assert(!(t1 == t2)); assert(!(t1 == t2));
assert(t1 != t2); assert(t1 != t2);
} }
{ {
typedef std::tuple<char, int, double> T1; typedef std::tuple<long, int, double> T1;
typedef std::tuple<double, char, int> T2; typedef std::tuple<double, long, int> T2;
const T1 t1(1, 2, 3); const T1 t1(1, 2, 3);
const T2 t2(1, 2, 4); const T2 t2(1, 2, 4);
assert(!(t1 == t2)); assert(!(t1 == t2));
assert(t1 != t2); assert(t1 != t2);
} }
{ {
typedef std::tuple<char, int, double> T1; typedef std::tuple<long, int, double> T1;
typedef std::tuple<double, char, int> T2; typedef std::tuple<double, long, int> T2;
const T1 t1(1, 2, 3); const T1 t1(1, 2, 3);
const T2 t2(1, 3, 2); const T2 t2(1, 3, 2);
assert(!(t1 == t2)); assert(!(t1 == t2));
assert(t1 != t2); assert(t1 != t2);
} }
{ {
typedef std::tuple<char, int, double> T1; typedef std::tuple<long, int, double> T1;
typedef std::tuple<double, char, int> T2; typedef std::tuple<double, long, int> T2;
const T1 t1(1, 2, 3); const T1 t1(1, 2, 3);
const T2 t2(1.1, 2, 2); const T2 t2(1.1, 2, 2);
assert(!(t1 == t2)); assert(!(t1 == t2));
assert(t1 != t2); assert(t1 != t2);
} }
{ {
typedef std::tuple<char, int, double> T1; typedef std::tuple<long, int, double> T1;
typedef std::tuple<double, char, int> T2; typedef std::tuple<double, long, int> T2;
const T1 t1(1, 2, 3); const T1 t1(1, 2, 3);
const T2 t2(1.1, 3, 3); const T2 t2(1.1, 3, 3);
assert(!(t1 == t2)); assert(!(t1 == t2));
assert(t1 != t2); assert(t1 != t2);
} }
{ {
typedef std::tuple<char, int, double> T1; typedef std::tuple<long, int, double> T1;
typedef std::tuple<double, char, int> T2; typedef std::tuple<double, long, int> T2;
const T1 t1(1, 2, 3); const T1 t1(1, 2, 3);
const T2 t2(1.1, 3, 2); const T2 t2(1.1, 3, 2);
assert(!(t1 == t2)); assert(!(t1 == t2));
assert(t1 != t2); assert(t1 != t2);
} }
#if TEST_STD_VER > 11 #if TEST_STD_VER > 11
{ {
typedef std::tuple<char, int, double> T1; typedef std::tuple<long, int, double> T1;
typedef std::tuple<double, char, int> T2; typedef std::tuple<double, long, int> T2;
constexpr T1 t1(1, 2, 3); constexpr T1 t1(1, 2, 3);
constexpr T2 t2(1.1, 3, 2); constexpr T2 t2(1.1, 3, 2);
static_assert(!(t1 == t2), ""); static_assert(!(t1 == t2), "");
static_assert(t1 != t2, ""); static_assert(t1 != t2, "");
} }
#endif #endif
} }

test/std/utilities/tuple/tuple.tuple/tuple.rel/lt.pass.cpp

Show First 20 Lines • Show All 42 Lines • ▼ Show 20 Linesint main()
const T1 t1; const T1 t1;
const T2 t2; const T2 t2;
assert(!(t1 < t2)); assert(!(t1 < t2));
assert( (t1 <= t2)); assert( (t1 <= t2));
assert(!(t1 > t2)); assert(!(t1 > t2));
assert( (t1 >= t2)); assert( (t1 >= t2));
} }
{ {
typedef std::tuple<char> T1; typedef std::tuple<long> T1;
typedef std::tuple<double> T2; typedef std::tuple<double> T2;
const T1 t1(1); const T1 t1(1);
const T2 t2(1); const T2 t2(1);
assert(!(t1 < t2)); assert(!(t1 < t2));
assert( (t1 <= t2)); assert( (t1 <= t2));
assert(!(t1 > t2)); assert(!(t1 > t2));
assert( (t1 >= t2)); assert( (t1 >= t2));
} }
{ {
typedef std::tuple<char> T1; typedef std::tuple<long> T1;
typedef std::tuple<double> T2; typedef std::tuple<double> T2;
const T1 t1(1); const T1 t1(1);
const T2 t2(0.9); const T2 t2(0.9);
assert(!(t1 < t2)); assert(!(t1 < t2));
assert(!(t1 <= t2)); assert(!(t1 <= t2));
assert( (t1 > t2)); assert( (t1 > t2));
assert( (t1 >= t2)); assert( (t1 >= t2));
} }
{ {
typedef std::tuple<char> T1; typedef std::tuple<long> T1;
typedef std::tuple<double> T2; typedef std::tuple<double> T2;
const T1 t1(1); const T1 t1(1);
const T2 t2(1.1); const T2 t2(1.1);
assert( (t1 < t2)); assert( (t1 < t2));
assert( (t1 <= t2)); assert( (t1 <= t2));
assert(!(t1 > t2)); assert(!(t1 > t2));
assert(!(t1 >= t2)); assert(!(t1 >= t2));
} }
{ {
typedef std::tuple<char, int> T1; typedef std::tuple<long, int> T1;
typedef std::tuple<double, char> T2; typedef std::tuple<double, long> T2;
const T1 t1(1, 2); const T1 t1(1, 2);
const T2 t2(1, 2); const T2 t2(1, 2);
assert(!(t1 < t2)); assert(!(t1 < t2));
assert( (t1 <= t2)); assert( (t1 <= t2));
assert(!(t1 > t2)); assert(!(t1 > t2));
assert( (t1 >= t2)); assert( (t1 >= t2));
} }
{ {
typedef std::tuple<char, int> T1; typedef std::tuple<long, int> T1;
typedef std::tuple<double, char> T2; typedef std::tuple<double, long> T2;
const T1 t1(1, 2); const T1 t1(1, 2);
const T2 t2(0.9, 2); const T2 t2(0.9, 2);
assert(!(t1 < t2)); assert(!(t1 < t2));
assert(!(t1 <= t2)); assert(!(t1 <= t2));
assert( (t1 > t2)); assert( (t1 > t2));
assert( (t1 >= t2)); assert( (t1 >= t2));
} }
{ {
typedef std::tuple<char, int> T1; typedef std::tuple<long, int> T1;
typedef std::tuple<double, char> T2; typedef std::tuple<double, long> T2;
const T1 t1(1, 2); const T1 t1(1, 2);
const T2 t2(1.1, 2); const T2 t2(1.1, 2);
assert( (t1 < t2)); assert( (t1 < t2));
assert( (t1 <= t2)); assert( (t1 <= t2));
assert(!(t1 > t2)); assert(!(t1 > t2));
assert(!(t1 >= t2)); assert(!(t1 >= t2));
} }
{ {
typedef std::tuple<char, int> T1; typedef std::tuple<long, int> T1;
typedef std::tuple<double, char> T2; typedef std::tuple<double, long> T2;
const T1 t1(1, 2); const T1 t1(1, 2);
const T2 t2(1, 1); const T2 t2(1, 1);
assert(!(t1 < t2)); assert(!(t1 < t2));
assert(!(t1 <= t2)); assert(!(t1 <= t2));
assert( (t1 > t2)); assert( (t1 > t2));
assert( (t1 >= t2)); assert( (t1 >= t2));
} }
{ {
typedef std::tuple<char, int> T1; typedef std::tuple<long, int> T1;
typedef std::tuple<double, char> T2; typedef std::tuple<double, long> T2;
const T1 t1(1, 2); const T1 t1(1, 2);
const T2 t2(1, 3); const T2 t2(1, 3);
assert( (t1 < t2)); assert( (t1 < t2));
assert( (t1 <= t2)); assert( (t1 <= t2));
assert(!(t1 > t2)); assert(!(t1 > t2));
assert(!(t1 >= t2)); assert(!(t1 >= t2));
} }
{ {
typedef std::tuple<char, int, double> T1; typedef std::tuple<long, int, double> T1;
typedef std::tuple<double, char, int> T2; typedef std::tuple<double, long, int> T2;
const T1 t1(1, 2, 3); const T1 t1(1, 2, 3);
const T2 t2(1, 2, 3); const T2 t2(1, 2, 3);
assert(!(t1 < t2)); assert(!(t1 < t2));
assert( (t1 <= t2)); assert( (t1 <= t2));
assert(!(t1 > t2)); assert(!(t1 > t2));
assert( (t1 >= t2)); assert( (t1 >= t2));
} }
{ {
typedef std::tuple<char, int, double> T1; typedef std::tuple<long, int, double> T1;
typedef std::tuple<double, char, int> T2; typedef std::tuple<double, long, int> T2;
const T1 t1(1, 2, 3); const T1 t1(1, 2, 3);
const T2 t2(0.9, 2, 3); const T2 t2(0.9, 2, 3);
assert(!(t1 < t2)); assert(!(t1 < t2));
assert(!(t1 <= t2)); assert(!(t1 <= t2));
assert( (t1 > t2)); assert( (t1 > t2));
assert( (t1 >= t2)); assert( (t1 >= t2));
} }
{ {
typedef std::tuple<char, int, double> T1; typedef std::tuple<long, int, double> T1;
typedef std::tuple<double, char, int> T2; typedef std::tuple<double, long, int> T2;
const T1 t1(1, 2, 3); const T1 t1(1, 2, 3);
const T2 t2(1.1, 2, 3); const T2 t2(1.1, 2, 3);
assert( (t1 < t2)); assert( (t1 < t2));
assert( (t1 <= t2)); assert( (t1 <= t2));
assert(!(t1 > t2)); assert(!(t1 > t2));
assert(!(t1 >= t2)); assert(!(t1 >= t2));
} }
{ {
typedef std::tuple<char, int, double> T1; typedef std::tuple<long, int, double> T1;
typedef std::tuple<double, char, int> T2; typedef std::tuple<double, long, int> T2;
const T1 t1(1, 2, 3); const T1 t1(1, 2, 3);
const T2 t2(1, 1, 3); const T2 t2(1, 1, 3);
assert(!(t1 < t2)); assert(!(t1 < t2));
assert(!(t1 <= t2)); assert(!(t1 <= t2));
assert( (t1 > t2)); assert( (t1 > t2));
assert( (t1 >= t2)); assert( (t1 >= t2));
} }
{ {
typedef std::tuple<char, int, double> T1; typedef std::tuple<long, int, double> T1;
typedef std::tuple<double, char, int> T2; typedef std::tuple<double, long, int> T2;
const T1 t1(1, 2, 3); const T1 t1(1, 2, 3);
const T2 t2(1, 3, 3); const T2 t2(1, 3, 3);
assert( (t1 < t2)); assert( (t1 < t2));
assert( (t1 <= t2)); assert( (t1 <= t2));
assert(!(t1 > t2)); assert(!(t1 > t2));
assert(!(t1 >= t2)); assert(!(t1 >= t2));
} }
{ {
typedef std::tuple<char, int, double> T1; typedef std::tuple<long, int, double> T1;
typedef std::tuple<double, char, int> T2; typedef std::tuple<double, long, int> T2;
const T1 t1(1, 2, 3); const T1 t1(1, 2, 3);
const T2 t2(1, 2, 2); const T2 t2(1, 2, 2);
assert(!(t1 < t2)); assert(!(t1 < t2));
assert(!(t1 <= t2)); assert(!(t1 <= t2));
assert( (t1 > t2)); assert( (t1 > t2));
assert( (t1 >= t2)); assert( (t1 >= t2));
} }
{ {
typedef std::tuple<char, int, double> T1; typedef std::tuple<long, int, double> T1;
typedef std::tuple<double, char, int> T2; typedef std::tuple<double, long, int> T2;
const T1 t1(1, 2, 3); const T1 t1(1, 2, 3);
const T2 t2(1, 2, 4); const T2 t2(1, 2, 4);
assert( (t1 < t2)); assert( (t1 < t2));
assert( (t1 <= t2)); assert( (t1 <= t2));
assert(!(t1 > t2)); assert(!(t1 > t2));
assert(!(t1 >= t2)); assert(!(t1 >= t2));
} }
#if TEST_STD_VER > 11 #if TEST_STD_VER > 11
{ {
typedef std::tuple<char, int, double> T1; typedef std::tuple<long, int, double> T1;
typedef std::tuple<double, char, int> T2; typedef std::tuple<double, long, int> T2;
constexpr T1 t1(1, 2, 3); constexpr T1 t1(1, 2, 3);
constexpr T2 t2(1, 2, 4); constexpr T2 t2(1, 2, 4);
static_assert( (t1 < t2), ""); static_assert( (t1 < t2), "");
static_assert( (t1 <= t2), ""); static_assert( (t1 <= t2), "");
static_assert(!(t1 > t2), ""); static_assert(!(t1 > t2), "");
static_assert(!(t1 >= t2), ""); static_assert(!(t1 >= t2), "");
} }
#endif #endif
} }