Page MenuHomePhabricator

AMDGPU/SI: Add a MachineMemOperand to MIMG instructions
ClosedPublic

Authored by tstellarAMD on Dec 7 2016, 1:14 PM.

Details

Summary

Without a MachineMemOperand, the scheduler was assuming MIMG instructions
were ordered memory references, so no loads or stores could be reordered
across them.

Diff Detail

Repository
rL LLVM

Event Timeline

tstellarAMD retitled this revision from to AMDGPU/SI: Add a MachineMemOperand to MIMG instructions.
tstellarAMD updated this object.
arsenm added a comment.Dec 7 2016, 1:18 PM

I thought we needed D13575 for this

lib/Target/AMDGPU/SIMachineFunctionInfo.h
31 ↗(On Diff #80646)

Why are these virtual? Are they supposed to be override?

arsenm added a comment.Dec 7 2016, 1:21 PM

Can you add a test where this changes the scheduling

Add test and address other comment.

tstellarAMD marked an inline comment as done.Dec 9 2016, 12:55 PM

I thought we needed D13575 for this

Yes, I was planning to commit that one first.

arsenm accepted this revision.Dec 9 2016, 1:07 PM
arsenm added a reviewer: arsenm.

LGTM

This revision is now accepted and ready to land.Dec 9 2016, 1:07 PM
This revision was automatically updated to reflect the committed changes.