This is an archive of the discontinued LLVM Phabricator instance.

Differential D27443

Replace "|&" with "2>&1 |" to support bash pre-4
ClosedPublic

Authored by bcain on Dec 5 2016, 6:21 PM.

Details

Reviewers
eugenis
Commits
rG74cf034805de: Replace "|&" with "2>&1 |" to support bash pre-4
rCRT288854: Replace "|&" with "2>&1 |" to support bash pre-4
rL288854: Replace "|&" with "2>&1 |" to support bash pre-4
Summary

Old bash release (3.2) on SLES11 chokes on new redirection shortcut.

Diff Detail

Repository
rL LLVM

Event Timeline

bcain updated this revision to Diff 80364.Dec 5 2016, 6:21 PM
bcain retitled this revision from to Replace "|&" with "2>&1 |" to support bash pre-4.
bcain updated this object.
bcain added a reviewer: eugenis.
bcain set the repository for this revision to rL LLVM.
Herald added a subscriber: kubamracek. · View Herald TranscriptDec 5 2016, 6:21 PM
eugenis accepted this revision.Dec 6 2016, 12:10 AM
eugenis edited edge metadata.
eugenis added a subscriber: llvm-commits.

LGTM

This revision is now accepted and ready to land.Dec 6 2016, 12:10 AM
Closed by commit rL288854: Replace "|&" with "2>&1 |" to support bash pre-4 (authored by eugenis). · Explain WhyDec 6 2016, 2:12 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
compiler-rt/
trunk/
test/
asan/
TestCases/
Linux/
4 lines
msan/
Linux/
2 lines
2 lines
2 lines
2 lines

Diff 80483

compiler-rt/trunk/test/asan/TestCases/Linux/new_delete_mismatch.cc

// Check that we report new[] vs delete as alloc-dealloc-mismatch and not as // Check that we report new[] vs delete as alloc-dealloc-mismatch and not as
// new-delete-type-mismatch when -fsized-deallocation is enabled. // new-delete-type-mismatch when -fsized-deallocation is enabled.
// RUN: %clangxx_asan -g %s -o %t && %env_asan_opts=alloc_dealloc_mismatch=1 not %run %t |& FileCheck %s // RUN: %clangxx_asan -g %s -o %t && %env_asan_opts=alloc_dealloc_mismatch=1 not %run %t 2>&1 | FileCheck %s
// RUN: %clangxx_asan -fsized-deallocation -g %s -o %t && %env_asan_opts=alloc_dealloc_mismatch=1 not %run %t |& FileCheck %s // RUN: %clangxx_asan -fsized-deallocation -g %s -o %t && %env_asan_opts=alloc_dealloc_mismatch=1 not %run %t 2>&1 | FileCheck %s
#include <stdlib.h> #include <stdlib.h>
static volatile char *x; static volatile char *x;
int main() { int main() {
x = new char[10]; x = new char[10];
delete x; delete x;
} }
// CHECK: AddressSanitizer: alloc-dealloc-mismatch (operator new [] vs operator delete) on 0x // CHECK: AddressSanitizer: alloc-dealloc-mismatch (operator new [] vs operator delete) on 0x

compiler-rt/trunk/test/msan/Linux/obstack.cc

// RUN: %clangxx_msan -O0 -g %s -o %t && %run %t // RUN: %clangxx_msan -O0 -g %s -o %t && %run %t
// RUN: %clangxx_msan -O0 -g -DPOSITIVE %s -o %t && not %run %t |& FileCheck %s // RUN: %clangxx_msan -O0 -g -DPOSITIVE %s -o %t && not %run %t 2>&1 | FileCheck %s
#include <obstack.h> #include <obstack.h>
#include <sanitizer/msan_interface.h> #include <sanitizer/msan_interface.h>
#include <stdlib.h> #include <stdlib.h>
static void *obstack_chunk_alloc(size_t sz) { static void *obstack_chunk_alloc(size_t sz) {
return malloc(sz); return malloc(sz);
} }
Show All 27 Lines

compiler-rt/trunk/test/msan/Linux/process_vm_readv.cc

// RUN: %clangxx_msan -std=c++11 -O0 %s -o %t && %run %t // RUN: %clangxx_msan -std=c++11 -O0 %s -o %t && %run %t
// RUN: %clangxx_msan -std=c++11 -O0 %s -o %t -DPOSITIVE && not %run %t |& FileCheck %s // RUN: %clangxx_msan -std=c++11 -O0 %s -o %t -DPOSITIVE && not %run %t 2>&1 | FileCheck %s
#include <assert.h> #include <assert.h>
#include <dlfcn.h> #include <dlfcn.h>
#include <sanitizer/msan_interface.h> #include <sanitizer/msan_interface.h>
#include <stdio.h> #include <stdio.h>
#include <string.h> #include <string.h>
#include <sys/types.h> #include <sys/types.h>
#include <sys/uio.h> #include <sys/uio.h>
▲ Show 20 Lines • Show All 65 Lines • Show Last 20 Lines

compiler-rt/trunk/test/msan/fork.cc

// Test that chained origins are fork-safe. // Test that chained origins are fork-safe.
// Run a number of threads that create new chained origins, then fork // Run a number of threads that create new chained origins, then fork
// and verify that origin reads do not deadlock in the child process. // and verify that origin reads do not deadlock in the child process.
// RUN: %clangxx_msan -std=c++11 -fsanitize-memory-track-origins=2 -g -O3 %s -o %t // RUN: %clangxx_msan -std=c++11 -fsanitize-memory-track-origins=2 -g -O3 %s -o %t
// RUN: MSAN_OPTIONS=store_context_size=1000,origin_history_size=0,origin_history_per_stack_limit=0 %run %t |& FileCheck %s // RUN: MSAN_OPTIONS=store_context_size=1000,origin_history_size=0,origin_history_per_stack_limit=0 %run %t 2>&1 | FileCheck %s
// Fun fact: if test output is redirected to a file (as opposed to // Fun fact: if test output is redirected to a file (as opposed to
// being piped directly to FileCheck), we may lose some "done"s due to // being piped directly to FileCheck), we may lose some "done"s due to
// a kernel bug: // a kernel bug:
// https://lkml.org/lkml/2014/2/17/324 // https://lkml.org/lkml/2014/2/17/324
// Flaky on PPC64. // Flaky on PPC64.
// UNSUPPORTED: powerpc64-target-arch // UNSUPPORTED: powerpc64-target-arch
▲ Show 20 Lines • Show All 110 Lines • Show Last 20 Lines

compiler-rt/trunk/test/msan/iconv.cc

// RUN: %clangxx_msan -O0 -g %s -o %t && %run %t // RUN: %clangxx_msan -O0 -g %s -o %t && %run %t
// RUN: %clangxx_msan -O0 -g -DPOSITIVE %s -o %t && not %run %t |& FileCheck %s // RUN: %clangxx_msan -O0 -g -DPOSITIVE %s -o %t && not %run %t 2>&1 | FileCheck %s
#include <assert.h> #include <assert.h>
#include <iconv.h> #include <iconv.h>
#include <stdlib.h> #include <stdlib.h>
#include <string.h> #include <string.h>
#include <stdio.h> #include <stdio.h>
#include <errno.h> #include <errno.h>
▲ Show 20 Lines • Show All 43 Lines • Show Last 20 Lines