This is an archive of the discontinued LLVM Phabricator instance.

Fix stack-use-after-scope in EvaluateImplicitExceptionSpec
ClosedPublic

Authored by vitalybuka on Dec 5 2016, 10:21 AM.

Reviewers

Commits

Summary

getExceptionSpec returns structure with pointers to temporarily object created
by computeImplicitExceptionSpec.

Build Status

Buildable 1858
Build 1858: arc lint + arc unit

vitalybuka retitled this revision from to Fix stack-use-after-scope in EvaluateImplicitExceptionSpec.

vitalybuka updated this object.

vitalybuka added a reviewer: rsmith.

This revision was automatically updated to reflect the committed changes.

Path

Size

lib/

Sema/

3 lines

	Show First 20 Lines • Show All 6,094 Lines • ▼ Show 20 Lines
	}			}

	void Sema::EvaluateImplicitExceptionSpec(SourceLocation Loc, CXXMethodDecl *MD) {			void Sema::EvaluateImplicitExceptionSpec(SourceLocation Loc, CXXMethodDecl *MD) {
	const FunctionProtoType *FPT = MD->getType()->castAs<FunctionProtoType>();			const FunctionProtoType *FPT = MD->getType()->castAs<FunctionProtoType>();
	if (FPT->getExceptionSpecType() != EST_Unevaluated)			if (FPT->getExceptionSpecType() != EST_Unevaluated)
	return;			return;

	// Evaluate the exception specification.			// Evaluate the exception specification.
	auto ESI = computeImplicitExceptionSpec(*this, Loc, MD).getExceptionSpec();			auto IES = computeImplicitExceptionSpec(*this, Loc, MD);
				auto ESI = IES.getExceptionSpec();

	// Update the type of the special member to use it.			// Update the type of the special member to use it.
	UpdateExceptionSpec(MD, ESI);			UpdateExceptionSpec(MD, ESI);

	// A user-provided destructor can be defined outside the class. When that			// A user-provided destructor can be defined outside the class. When that
	// happens, be sure to update the exception specification on both			// happens, be sure to update the exception specification on both
	// declarations.			// declarations.
	const FunctionProtoType *CanonicalFPT =			const FunctionProtoType *CanonicalFPT =
	▲ Show 20 Lines • Show All 8,743 Lines • Show Last 20 Lines