[PM] Rename lookupPass to lookUpPass.

[jlebar]

Summary

"Lookup" is a noun ("lookup table"), "look up" is a verb ("look up
'table' in the dictionary").

[silvas]

If you feel strongly about this then go ahead, though if you're renaming this better to rename it lookUpAnalysis.

[jlebar]

if you're renaming this better to rename it lookUpAnalysis.

I left it as "lookUpPass" because a lot of the analysis code talks about "passes", or sometimes "analysis passes".

Should we excise mentions of "pass" from the analysis parts? I can write that patch if you think it's the terminology we want to adopt.

[silvas]

In D27374#613686, @jlebar wrote:

if you're renaming this better to rename it lookUpAnalysis.

I left it as "lookUpPass" because a lot of the analysis code talks about "passes", or sometimes "analysis passes".

Should we excise mentions of "pass" from the analysis parts? I can write that patch if you think it's the terminology we want to adopt.

Check with Chandler, but "pass" is really an old-PM concept. The new-PM has analyses and transformations. Sure, we can call them "analysis passes" and "transformation passes" but then what does "pass" by itself mean? It doesn't mean anything. In fact, the only thing that I can think of which is shared between analyses and transformations is PassInfoMixin but it feels incidental; it's just a mixin for adding a name method to get the class name and there are currently no transformation-specific things needed in that mixin so it gets reused for analyses.

[mehdi_amini]

In D27374#614239, @silvas wrote:

Check with Chandler, but "pass" is really an old-PM concept. The new-PM has analyses and transformations.

So will the new-PM lose its acronym meaning just like LLVM did itself? ;)

llvm/trunk/include/llvm/IR/PassManager.h

if (!IsResultInvalidated.empty()) {
       }
     }
 
     if (ResultsList.empty())
       AnalysisResultLists.erase(&IR);
   }
 
 private:
-  /// \brief Lookup a registered analysis pass.
-  PassConceptT &lookupPass(AnalysisKey *ID) {
+  /// \brief Look up a registered analysis pass.
+  PassConceptT &lookUpPass(AnalysisKey *ID) {
     typename AnalysisPassMapT::iterator PI = AnalysisPasses.find(ID);
     assert(PI != AnalysisPasses.end() &&
            "Analysis passes must be registered prior to being queried!");
     return *PI->second;
   }
 
-  /// \brief Lookup a registered analysis pass.
-  const PassConceptT &lookupPass(AnalysisKey *ID) const {
+  /// \brief Look up a registered analysis pass.
+  const PassConceptT &lookUpPass(AnalysisKey *ID) const {
     typename AnalysisPassMapT::const_iterator PI = AnalysisPasses.find(ID);
     assert(PI != AnalysisPasses.end() &&
            "Analysis passes must be registered prior to being queried!");
     return *PI->second;
   }
 
   /// \brief Get an analysis result, running the pass if necessary.
   ResultConceptT &getResultImpl(AnalysisKey *ID, IRUnitT &IR,
                                 ExtraArgTs... ExtraArgs) {
     typename AnalysisResultMapT::iterator RI;
     bool Inserted;
     std::tie(RI, Inserted) = AnalysisResults.insert(std::make_pair(
         std::make_pair(ID, &IR), typename AnalysisResultListT::iterator()));
 
     // If we don't have a cached result for this function, look up the pass and
     // run it to produce a result, which we then add to the cache.
     if (Inserted) {
-      auto &P = this->lookupPass(ID);
+      auto &P = this->lookUpPass(ID);
       if (DebugLogging)
         dbgs() << "Running analysis: " << P.name() << "\n";
       AnalysisResultListT &ResultList = AnalysisResultLists[&IR];
       ResultList.emplace_back(ID, P.run(IR, *this, ExtraArgs...));
 
       // P.run may have inserted elements into AnalysisResults and invalidated
       // RI.
       RI = AnalysisResults.find({ID, &IR});
private:
   /// \brief Invalidate a function pass result.
   void invalidateImpl(AnalysisKey *ID, IRUnitT &IR) {
     typename AnalysisResultMapT::iterator RI =
         AnalysisResults.find({ID, &IR});
     if (RI == AnalysisResults.end())
       return;
 
     if (DebugLogging)
-      dbgs() << "Invalidating analysis: " << this->lookupPass(ID).name()
+      dbgs() << "Invalidating analysis: " << this->lookUpPass(ID).name()
              << "\n";
     AnalysisResultLists[&IR].erase(RI->second);
     AnalysisResults.erase(RI);
   }
 
   /// \brief Map type from module analysis pass ID to pass concept pointer.
   typedef DenseMap<AnalysisKey *, std::unique_ptr<PassConceptT>> AnalysisPassMapT;