This is an archive of the discontinued LLVM Phabricator instance.

[PM] Make AnalysisManager::registerPass take its parameter by universal reference.
ClosedPublic

Authored by jlebar on Dec 2 2016, 4:01 PM.

Details

Summary

Previously, we were forcing a copy if you passed an lvalue argument; now
we'll take it by reference.

Diff Detail

Repository
rL LLVM

Event Timeline

jlebar updated this revision to Diff 80145.Dec 2 2016, 4:01 PM
jlebar retitled this revision from to [PM] Make AnalysisManager::registerPass take its parameter by universal reference..
jlebar updated this object.
jlebar added a reviewer: chandlerc.
jlebar added subscribers: llvm-commits, silvas.
silvas added a comment.Dec 2 2016, 9:28 PM

This is fine, but it doesn't really matter; this is only called like once for an entire compilation (it's basically a hack to set a pipeline-global closure for a particular analysis; only AA uses it now)

Thank you for the reviews on this patch queue, Sean!

This revision was automatically updated to reflect the committed changes.