This is an archive of the discontinued LLVM Phabricator instance.

Protect optional test under libcpp-no-exceptions
ClosedPublic

Authored by rogfer01 on Nov 30 2016, 3:38 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

rogfer01 updated this revision to Diff 79719.Nov 30 2016, 3:38 AM
rogfer01 retitled this revision from to Protect optional test under libcpp-no-exceptions.
rogfer01 updated this object.
rogfer01 added reviewers: mclow.lists, EricWF, rmaprath.
rogfer01 added a subscriber: cfe-commits.
mclow.lists added inline comments.Nov 30 2016, 7:23 AM
test/std/experimental/optional/optional.specalg/swap.pass.cpp
225 ↗(On Diff #79719)

Why is this here, and not before line L#236?

rogfer01 added inline comments.Nov 30 2016, 9:20 AM
test/std/experimental/optional/optional.specalg/swap.pass.cpp
225 ↗(On Diff #79719)

Yep, I'm wrong here. Probably a fallout of an early version where I protected the definition of Z instead before using TEST_THROW.

rogfer01 updated this revision to Diff 79765.Nov 30 2016, 9:25 AM
rogfer01 edited edge metadata.

Protect the right set of tests.

mclow.lists accepted this revision.Nov 30 2016, 12:23 PM
mclow.lists edited edge metadata.

Looks good now - thanks.

This revision is now accepted and ready to land.Nov 30 2016, 12:23 PM
This revision was automatically updated to reflect the committed changes.